Merge pull request #51 from wkarl/feature/local-storage-namespaces

Add mandatory namespace constructor argument to prevent unexpected behaviour when two instances access the same key

README.md

@@ -7,7 +7,7 @@
 Evaluate JavaScript code and map values, objects and functions between Kotlin/Java and JavaScript on Android.
 
 ```kotlin
-val jsBridge = JsBridge(JsBridgeConfig.bareConfig())
+val jsBridge = JsBridge(JsBridgeConfig.bareConfig(), context, "namespace")
 val msg: String = jsBridge.evaluate("'Hello world!'.toUpperCase()")
 println(msg)  // HELLO WORLD!
 ```
@@ -404,7 +404,7 @@ val javaApi = object: JavaApi {
 
 Bridging JavaScript and Kotlin:
 ```kotlin
-val jsBridge = JsBridge(JsBridgeConfig.standardConfig())
+val jsBridge = JsBridge(JsBridgeConfig.standardConfig(), context, "namespace")
 jsBridge.evaluateLocalFile(context, "js/api.js")
 
 // JS "proxy" to Java API

jsbridge/src/androidTest/kotlin/de/prosiebensat1digital/oasisjsbridge/JsBridgeJavaTest.java

@@ -123,7 +123,7 @@ public void testRegisterJavaToJs() {
     // ---
 
     private JsBridge createAndSetUpJsBridge() {
-        JsBridge jsBridge = new JsBridge(JsBridgeConfig.standardConfig(), context);
+        JsBridge jsBridge = new JsBridge(JsBridgeConfig.standardConfig(), context, "test_namespace");
         this.jsBridge = jsBridge;
         return jsBridge;
     }

jsbridge/src/androidTest/kotlin/de/prosiebensat1digital/oasisjsbridge/JsBridgeTest.kt

@@ -76,6 +76,8 @@ interface JsExpectationsJavaApi : JsToJavaInterface {
     fun addExpectation(name: String, value: JsValue)
 }
 
+private const val NAMESPACE = "test_namespace"
+
 class JsBridgeTest {
     private var jsBridge: JsBridge? = null
     private val context: Context = InstrumentationRegistry.getInstrumentation().context
@@ -1236,7 +1238,7 @@ class JsBridgeTest {
         val config = JsBridgeConfig.standardConfig().apply {
             xhrConfig.okHttpClient = okHttpClient
         }
-        val subject = JsBridge(config, context)
+        val subject = JsBridge(config, context, NAMESPACE)
 
         val jsExpectations = JsExpectations()
         val jsExpectationsJsValue = JsValue.createJsToJavaProxy(subject, jsExpectations)
@@ -1607,7 +1609,7 @@ class JsBridgeTest {
         val config = JsBridgeConfig.standardConfig().apply {
             xhrConfig.okHttpClient = okHttpClient
         }
-        val subject = JsBridge(config, context)
+        val subject = JsBridge(config, context, NAMESPACE)
 
         val jsExpectations = JsExpectations()
         val jsExpectationsJsValue = JsValue.createJsToJavaProxy(subject, jsExpectations)
@@ -2737,7 +2739,7 @@ class JsBridgeTest {
                 messages.add(priority to message)
             }
         }
-        val subject = JsBridge(config, context)
+        val subject = JsBridge(config, context, NAMESPACE)
         jsBridge = subject
 
         // WHEN
@@ -2775,7 +2777,7 @@ class JsBridgeTest {
                 messages.add(priority to message)
             }
         }
-        val subject = JsBridge(config, context)
+        val subject = JsBridge(config, context, NAMESPACE)
         jsBridge = subject
 
         // WHEN
@@ -2813,7 +2815,7 @@ class JsBridgeTest {
                 hasMessage = true
             }
         }
-        val subject = JsBridge(config, context)
+        val subject = JsBridge(config, context, NAMESPACE)
         jsBridge = subject
 
         // WHEN
@@ -2840,11 +2842,11 @@ class JsBridgeTest {
         val subject = createAndSetUpJsBridge()
 
         // WHEN
-        subject.evaluateBlocking<Unit>("""localStorage.setItem("foo", "bar");""")
-        val result = subject.evaluateBlocking<String>("""localStorage.getItem("foo");""")
+        subject.evaluateBlocking<Unit>("""localStorage.setItem("key", "value");""")
+        val result = subject.evaluateBlocking<String>("""localStorage.getItem("key");""")
 
         // THEN
-        assertEquals(result, "bar")
+        assertEquals("value", result)
         assertTrue(errors.isEmpty())
 
         // GIVEN
@@ -2860,7 +2862,26 @@ class JsBridgeTest {
         assertTrue(errors.isEmpty())
     }
 
+    @Test
+    fun testLocalStorageNamespaces() {
+        // GIVEN
+        val subject1 = createAndSetUpJsBridge()
+        val subject2 = createAndSetUpJsBridge(namespace = "other_namespace")
+
+        // WHEN
+        subject1.evaluateBlocking<Unit>("""localStorage.setItem("key", "value");""")
+        subject1.evaluateBlocking<Unit>("""localStorage.setItem("key2", "value");""")
+        val result1 = subject1.evaluateBlocking<String>("""localStorage.getItem("key");""")
+        subject2.evaluateBlocking<Unit>("""localStorage.setItem("key", "TEST");""")
+        val result2 = subject2.evaluateBlocking<String>("""localStorage.getItem("key");""")
+        val result3 = subject2.evaluateBlocking<String>("""localStorage.getItem("key2");""")
 
+        // THEN
+        assertEquals("value", result1)
+        assertEquals("TEST", result2)
+        assertNull(result3)
+        assertTrue(errors.isEmpty())
+    }
     data class EmbeddedObject(val a: Int, val b: String)
 
     @Test
@@ -3003,10 +3024,11 @@ class JsBridgeTest {
     private fun createAndSetUpJsBridge(
         config: JsBridgeConfig = JsBridgeConfig.standardConfig().apply {
             xhrConfig.okHttpClient = okHttpClient
-        }
+        },
+        namespace: String = NAMESPACE,
     ): JsBridge {
 
-        return JsBridge(config, context).also { jsBridge ->
+        return JsBridge(config, context, namespace).also { jsBridge ->
             this@JsBridgeTest.jsBridge = jsBridge
 
             jsBridge.registerErrorListener(createErrorListener())

jsbridge/src/androidTest/kotlin/de/prosiebensat1digital/oasisjsbridge/ReadmeTest.kt

@@ -39,7 +39,7 @@ class ReadmeTest {
 
     @Before
     fun setUp() {
-        jsBridge = JsBridge(JsBridgeConfig.standardConfig(), context)
+        jsBridge = JsBridge(JsBridgeConfig.standardConfig(), context,"test_namespace")
     }
 
     @After

jsbridge/src/main/kotlin/de/prosiebensat1digital/oasisjsbridge/JsBridge.kt

@@ -56,9 +56,13 @@ import java.lang.reflect.Proxy
  * Note: all the public methods are asynchronous and will not block the caller threads. They
  * can be safely called in a "synchronous" way. though, because their executions are guaranteed
  * to be performed sequentially (via an internal queue).
+ *
+ * @param config JsBridge configuration
+ * @param context Context needed for built in implementation of local storage
+ * @param namespace arbitrary string for separation of local storage between multiple JsBridge instances
  */
 class JsBridge
-    constructor(config: JsBridgeConfig, context: Context) : CoroutineScope {
+    constructor(config: JsBridgeConfig, context: Context, namespace: String) : CoroutineScope {
 
     companion object {
         private var isLibraryLoaded = false
@@ -157,7 +161,7 @@ class JsBridge
             if (config.xhrConfig.enabled)
                 xhrExtension = XMLHttpRequestExtension(this@JsBridge, config.xhrConfig)
             if (config.localStorageConfig.enabled)
-                localStorageExtension = LocalStorageExtension(this@JsBridge, config.localStorageConfig, context.applicationContext)
+                localStorageExtension = LocalStorageExtension(this@JsBridge, config.localStorageConfig, context.applicationContext, namespace)
             config.jvmConfig.customClassLoader?.let { customClassLoader = it }
         }
     }

jsbridge/src/main/kotlin/de/prosiebensat1digital/oasisjsbridge/extensions/LocalStorage.kt

@@ -13,10 +13,10 @@ interface LocalStorageInteface : JsToJavaInterface {
     fun clear()
 }
 
-class LocalStorage(context: Context) : LocalStorageInteface {
+class LocalStorage(context: Context, namespace: String) : LocalStorageInteface {
 
     private val localStoragePreferences = context.getSharedPreferences(
-        context.applicationInfo.packageName + ".LOCAL_STORAGE_PREFERENCE_FILE_KEY",
+        "${namespace.takeIf { it.isNotEmpty() } ?: "default"}.LOCAL_STORAGE_PREFERENCES",
         Context.MODE_PRIVATE
     )
 

jsbridge/src/main/kotlin/de/prosiebensat1digital/oasisjsbridge/extensions/LocalStorageExtension.kt

@@ -21,14 +21,15 @@ import de.prosiebensat1digital.oasisjsbridge.JsBridgeConfig
 import de.prosiebensat1digital.oasisjsbridge.JsValue
 
 internal class LocalStorageExtension(
-    private val jsBridge: JsBridge,
-    val config: JsBridgeConfig.LocalStorageConfig,
+    jsBridge: JsBridge,
+    config: JsBridgeConfig.LocalStorageConfig,
     context: Context,
+    namespace: String,
 ) {
 
     init {
         if (config.useDefaultLocalStorage) {
-            val localStorage: LocalStorageInteface = LocalStorage(context)
+            val localStorage: LocalStorageInteface = LocalStorage(context, namespace)
             val localStorageJsValue = JsValue.createJsToJavaProxy(jsBridge, localStorage)
             localStorageJsValue.assignToGlobal("localStorage")
         }