Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The object name "NodeDelegateModel" is misleading. #389

Open
QiuYilin opened this issue May 11, 2023 · 1 comment
Open

The object name "NodeDelegateModel" is misleading. #389

QiuYilin opened this issue May 11, 2023 · 1 comment

Comments

@QiuYilin
Copy link

QiuYilin commented May 11, 2023

NodeEditor is one of the few open source flow graph QT libraries. I can understand the intent of QT's MVD pattern from simplegraph example.But the NodeDelegateModel concept confused me. I think it is not a "Delegate" or "Model" in "MVD". It is more like Data containing In/Out member and a compute function because nodedelegatemodel is stored directly in DataflowGraphModel. Maybe existing pattern and "NodeDelegateModel" obj can be given other names.

I've been thinking about it lately. If the nodeeditor is strictly designed as MVD in the future, how should it be desigened? A generic flow graph pattern is more valuable than more and more functional details.

@QiuYilin
Copy link
Author

Thanks to nodeeditor for the inspiration.In my subsequent practice, I think this approach will be more versatile and reduce the amount of development: the data flow display framework does not bear the responsibility of propagating node data, but only provides logical APIs such as node connection. As for data flow propagation and dependency resolution, users need to implement feature-rich graph structures and related algorithms based on the basic model. It may be healthier to strengthen the functions at the view level while avoiding complex business requirements of the model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant