Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return OpenScanHub log files without download link #2644

Closed
1 of 2 tasks
Venefilyn opened this issue Nov 14, 2024 · 3 comments
Closed
1 of 2 tasks

Return OpenScanHub log files without download link #2644

Venefilyn opened this issue Nov 14, 2024 · 3 comments
Labels
kind/feature New feature or a request for enhancement.

Comments

@Venefilyn
Copy link
Contributor

Description

Currently all log files are download links, i.e. has ?format=raw in the URL. As this will start a download it might not be the best to return that. Instead to me it would make more sense to return the URL without query parameters and if needed you can add it to any clients utilizing the API.

Benefit

Less complexity, more freedom to handle links how we need to instead of formatting.

Importance

For dashboard, medium priority. There is a workaround that can be done which would be to parse the URL and remove the ?format=raw before displaying it.

What is the impacted category (job)?

Other

Workaround

  • There is an existing workaround that can be used until this feature is implemented.

Participation

  • I am willing to submit a pull request for this issue. (Packit team is happy to help!)
@Venefilyn Venefilyn added the kind/feature New feature or a request for enhancement. label Nov 14, 2024
@mfocko
Copy link
Member

mfocko commented Nov 18, 2024

Again, please go against OpenScanHub. Briefly checking the links that we have on dashboard, it might be just an issue of the HTTP server configuration, as without ?format=raw I get a full page with styles and everything. With ?format=raw it's just “raw” logs as the name suggests (though it might be handled by the server as a file to download rather than display).

@Venefilyn
Copy link
Contributor Author

Venefilyn commented Nov 18, 2024

Again, please go against OpenScanHub

Thought this was a Packit thing. Nonetheless, opened issue here openscanhub/openscanhub#304. If it changes in the future I would want to see if we can update the DB to all be https for the older entries

@majamassarini
Copy link
Member

We keep this card for updating the db.
Closing the issue since now it is on openscanhub side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or a request for enhancement.
Projects
Status: done
Development

No branches or pull requests

3 participants