Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pact-jvm junit5 documentation is outdated #1786

Closed
chenbojian opened this issue Apr 7, 2024 · 2 comments
Closed

pact-jvm junit5 documentation is outdated #1786

chenbojian opened this issue Apr 7, 2024 · 2 comments
Labels
bug Indicates an unexpected problem or unintended behavior

Comments

@chenbojian
Copy link

The online documentation https://docs.pact.io/implementation_guides/jvm/consumer/junit5 is an old version.

The createPact method is not compatible with V4Pact.

But the content in github https://github.com/pact-foundation/pact-jvm/blob/master/consumer/junit5/README.md have a note for different syntax.
https://github.com/pact-foundation/pact-jvm/blob/master/consumer/junit5/README.md#2-create-a-method-annotated-with-pact-that-returns-the-interactions-for-the-test

@rholshausen rholshausen added the bug Indicates an unexpected problem or unintended behavior label Apr 22, 2024
@rholshausen
Copy link
Contributor

Thanks for reporting this, the docs have now been synced

@YOU54F
Copy link
Member

YOU54F commented Apr 23, 2024

Thanks @chenbojian - our credentials for our docs sync job had expired, Ron pushed the changes manually yesterday and I've sorted the creds by switching to using our org level secret, which means it will updated in the future

sync job run in the docs repo, triggered by this repo

https://github.com/pact-foundation/docs.pact.io/actions/runs/8802450634/job/24158192257

@YOU54F YOU54F closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

3 participants