Fix bug resolving enum across multiple files. #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks for the PR! |
This was referenced Sep 20, 2023
|
@rholshausen or @mefellows - Would it be possible to trigger a bug fix release with this patch? We have a couple of folks who are looking to have this to unblock themselves. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In utils.rs, the
find_enum_by_nameandfind_enum_by_name_in_messagefunctions only look at the first descriptor that matches the package name. If there are multiple top-level descriptors with the same package name, the plugin doesn't look at each of them.The unit test attached reproduces this issue when tested against the previous version.
Issue: #30