Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In utils.rs, the
find_enum_by_name
andfind_enum_by_name_in_message
functions assume the enum is the last part of the full enum path and that the rest of the enum path is the package. It does not consider that the enum may be nested within another message. This results in the plugin searching for the enum.some.package.TestMessage.TestEnum
in the "package".some.package.TestMessage
which is not actually a package, and thus it does not find it.The unit test added reproduces this issue when tested against the previous version.
NOTE: I made the decision to only support one layer of nested enum rather than infinitely nested messages and enums to keep it simpler.
Issue: #36