Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macos-14 runner (arm64) failure to invoke protoc, with homebrew protobuf version 26.1. #63

Closed
YOU54F opened this issue May 14, 2024 · 2 comments

Comments

@YOU54F
Copy link
Member

YOU54F commented May 14, 2024

I have some gRPC tests which run against multiple runners.

I noted failures, without any codechanges on the macos-14 gha runner.

I have a step to install protobuf from homebrew

The only thing that has changed between the runs, is the version of protobuf held by homebrew, which was updated on the 1st April to 26.1 from 25.3 (commit)

Pinning the version to 25.3 with setup-protoc action resolves the issue in my test runs.

The screenshot below shows the original issue, a passing run three months ago

Screenshot 2024-05-15 at 00 25 39

The change was removing cirrus-ci in this commit

and the failing build, with the install of proto 26.1

Screenshot 2024-05-15 at 00 27 22

I think it would be nice to update the default version of protoc so it supports arm, meaning a user doesn't have to manually install it

related #33

It would still be a problem for users who have protoc 26.x installed.

Not sure what the actual root cause is, but thought I would just document here whilst its fresh in my mind

YOU54F added a commit that referenced this issue Jul 23, 2024
fixes #63 / #33 

works OOB with MacOS aarch64. 

26.x/27.x fail on MacOS aarch64 for integrations with via pact_ffi for

- php
- swift
- dotnet
- lua
@YOU54F
Copy link
Member Author

YOU54F commented Jul 23, 2024

Protobuf 27.x is also broken, when loading the pact-protobuf-plugin on macos-arm via the pact_ffi in PHP, Swift, Dotnet, Lua

@YOU54F
Copy link
Member Author

YOU54F commented Jul 23, 2024

0.4.0 of pact-protobuf-plugin now includes 21.12 version of protocol buffers, which supports macos arm64 so I won't need to manually install protobuf compilers. Can't use homebrew as it always points to the latest. Closing as I'm not sure if its an issue we need to solve at our side.

@YOU54F YOU54F closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant