Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-432] Development Push notifications for Android #6416

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Nov 18, 2024

Short description

This PR enables testing of push notifications for the development environment on Android.

List of changes proposed in this pull request

  • Mock google-services.json file removed in favour of a development one
  • Such file contains configuration ids and api keys that link to the Firebase development project. Its content is normally embedded into the application bundle and it is easily extracted so it does not contain any secret that should not be committed.
  • Code that avoided push notification initialisation on Android has been removed, since we now have a valid configuration file
  • Note that this works only on Android. iOS sandbox is not supported yet

How to test

Using the io-dev-api server, run the application on a real device or on an emulator that uses a Google Play Services image. Use the Firebase Console to send and receive a push notification.

@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-432] Development Push notifications for Android chore(Cross): [IOAPPX-432] Development Push notifications for Android Nov 18, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 18, 2024

Affected stories

  • ⚙️ IOAPPX-432: Creazione e configurazione del progetto Firebase per inviare e ricevere notifiche push su Android in fase di sviluppo

Generated by 🚫 dangerJS against 1765e13

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.12%. Comparing base (4f204b4) to head (1765e13).
Report is 795 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6416      +/-   ##
==========================================
- Coverage   48.42%   48.12%   -0.31%     
==========================================
  Files        1488     1628     +140     
  Lines       31617    32676    +1059     
  Branches     7669     7492     -177     
==========================================
+ Hits        15311    15724     +413     
- Misses      16238    16907     +669     
+ Partials       68       45      -23     
Files with missing lines Coverage Δ
...shNotifications/utils/configurePushNotification.ts 13.88% <ø> (ø)

... and 1690 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4136f6d...1765e13. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants