Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOCOM-1897] Remove Green Pass #6427

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

feat: [IOCOM-1897] Remove Green Pass #6427

wants to merge 26 commits into from

Conversation

Vangaorth
Copy link
Contributor

@Vangaorth Vangaorth commented Nov 19, 2024

Short description

This PR removes the legacy Green Pass code.

iOS Android
GreenPassiOS GreenPassAndroid

List of changes proposed in this pull request

  • All related green pass code has been removed
  • New screen to handle message selection
  • [extra] Remove legacy pictograms by refactoring the legacy screens using OperationResultScreenContent
  • [extra] Remove DSLegacyPictograms from the DS section

How to test

Using the related branch on io-dev-api-server, check that messages still work and that Green Pass messages are handled with the new screen.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1897] Remove Green Pass feat: [IOCOM-1897] Remove Green Pass Nov 19, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 19, 2024

Affected stories

  • 🌟 IOCOM-1897: Rimozione messaggi Green Pass
    subtask of

Generated by 🚫 dangerJS against cc753e3

@Vangaorth Vangaorth marked this pull request as ready for review November 19, 2024 16:48
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes missing coverage. Please review.

Project coverage is 47.85%. Comparing base (4f204b4) to head (cc753e3).
Report is 795 commits behind head on master.

Files with missing lines Patch % Lines
ts/components/screens/GenericErrorComponent.tsx 0.00% 3 Missing ⚠️
.../features/messages/screens/MessageRouterScreen.tsx 0.00% 1 Missing ⚠️
...ens/onboarding/ServicePreferenceCompleteScreen.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6427      +/-   ##
==========================================
- Coverage   48.42%   47.85%   -0.58%     
==========================================
  Files        1488     1579      +91     
  Lines       31617    32182     +565     
  Branches     7669     7342     -327     
==========================================
+ Hits        15311    15400      +89     
- Misses      16238    16740     +502     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
ts/config.ts 100.00% <ø> (ø)
.../features/bonus/cdc/components/CdcGenericError.tsx 100.00% <ø> (ø)
...tures/bonus/cdc/components/CdcRequestCompleted.tsx 100.00% <ø> (ø)
...onus/cdc/components/CdcRequestPartiallySuccess.tsx 100.00% <ø> (ø)
...s/features/bonus/cdc/components/CdcWrongFormat.tsx 100.00% <ø> (ø)
...ures/bonus/common/components/TosBonusComponent.tsx 7.14% <ø> (ø)
ts/features/common/store/reducers/index.ts 100.00% <ø> (ø)
ts/features/design-system/navigation/navigator.tsx 17.64% <ø> (-5.22%) ⬇️
ts/features/design-system/navigation/routes.ts 100.00% <ø> (ø)
...features/messages/navigation/MessagesNavigator.tsx 33.33% <ø> (+17.94%) ⬆️
... and 16 more

... and 1670 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4136f6d...cc753e3. Read the comment docs.

@dmnplb dmnplb added the 💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed label Nov 20, 2024
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested the following scenarios from a clean build on an Android 9 device:

  • Open a payment receipt and save it in the local storage;
  • Open a COVID message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💀 Dead matter Graphic assets or chunks of code that are no longer referenced or needed dont-merge ✋ IO-Comunicazione
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants