Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(IT Wallet): [SIW-1873] Fix useMaxBrightness flickering on iOS #6466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Nov 26, 2024

Short description

On iOS, displaying the QR Code of the Trustmark causes the screen brightness to flicker. This issue is due to a double animation triggered by an unexpected AppState change.
This PR introduces a check to prevent the double animation, ensuring smooth screen brightness transitions without flickering.

List of changes proposed in this pull request

  • Added a check on app state change in useMaxBrigthness

How to test

Open the Trustmark QR Code modal on iOS, check that the brightness is not flickering and reaches the maximum value smoothly

@pagopa-github-bot pagopa-github-bot changed the title [SIW-1873] Fix useMaxBrightness flickering on iOS fix(IT Wallet): [SIW-1873] Fix useMaxBrightness flickering on iOS Nov 26, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 26, 2024

Affected stories

  • 🐞 SIW-1873: [io-app] La luminosità dello schermo "traballa" quando viene visualizzato il trustmark su iOS

Generated by 🚫 dangerJS against 9103480

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 48.14%. Comparing base (4f204b4) to head (9103480).
Report is 795 commits behind head on master.

Files with missing lines Patch % Lines
ts/utils/brightness.ts 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6466      +/-   ##
==========================================
- Coverage   48.42%   48.14%   -0.29%     
==========================================
  Files        1488     1629     +141     
  Lines       31617    32692    +1075     
  Branches     7669     7491     -178     
==========================================
+ Hits        15311    15740     +429     
- Misses      16238    16895     +657     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
ts/utils/brightness.ts 4.41% <0.00%> (-8.93%) ⬇️

... and 1688 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb7e753...9103480. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants