Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-648] Enable SPID logs on hub spid login (ioweb instance) #676

Merged
merged 13 commits into from
Sep 22, 2023
Merged

[#IOPID-648] Enable SPID logs on hub spid login (ioweb instance) #676

merged 13 commits into from
Sep 22, 2023

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Sep 13, 2023 •
edited
Loading

This PR depends on pagopa/hub-spid-login-ms#94

List of changes

  • Add new storage and contaner for SPID logs
  • Add new private key for SPID logs
  • Link new storage in hub-spid-login instance
  • Update JWT token issuer (set to api-web.io.pagopa.it/ioweb/auth)

Motivation and context

Enable SPID logs on hub spid login (ioweb instance)

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@gquadrati gquadrati temporarily deployed to prod-runner September 13, 2023 14:58 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 13, 2023 15:00 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 13, 2023 15:03 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 13, 2023 15:05 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 13, 2023 15:53 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 13, 2023 15:54 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 13, 2023 15:57 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 15, 2023 16:01 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 15, 2023 16:02 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 15, 2023 16:04 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 18, 2023 16:45 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 18, 2023 16:46 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 18, 2023 16:46 — with GitHub Actions Inactive
@gquadrati gquadrati marked this pull request as ready for review September 18, 2023 16:46
@gquadrati gquadrati requested a review from a team September 18, 2023 16:46
@gquadrati gquadrati requested review from a team as code owners September 18, 2023 16:46
@gquadrati gquadrati temporarily deployed to prod-ci September 18, 2023 16:47 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 18, 2023 16:50 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 19, 2023 07:26 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 19, 2023 07:27 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 19, 2023 07:30 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 21, 2023 19:38 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 21, 2023 19:39 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 21, 2023 19:42 — with GitHub Actions Inactive
@dpulls
Copy link

dpulls bot commented Sep 22, 2023

🎉 All dependencies have been resolved !

@gquadrati gquadrati temporarily deployed to prod-runner September 22, 2023 14:46 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati temporarily deployed to prod-ci September 22, 2023 14:48 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 22, 2023 14:51 — with GitHub Actions Inactive
BurnedMarshal
BurnedMarshal approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@BurnedMarshal BurnedMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gquadrati gquadrati merged commit 95acde1 into main Sep 22, 2023
7 checks passed
@gquadrati gquadrati deleted the IOPID-648 branch September 22, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurnedMarshal BurnedMarshal BurnedMarshal approved these changes

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

@iwoak iwoak Awaiting requested review from iwoak iwoak is a code owner automatically assigned from pagopa/io-backend-contributors

@francescopersico francescopersico Awaiting requested review from francescopersico francescopersico is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @BurnedMarshal