Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAS-841] Update business name filter to be case-insensitive #11

Merged
merged 1 commit into from
Mar 15, 2024
Merged

[VAS-841] Update business name filter to be case-insensitive #11

merged 1 commit into from
Mar 15, 2024

Conversation

gioelemella
Copy link
Collaborator

List of Changes

  • updated businessName filter to be case-insensitive
  • updated unit test

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gioelemella gioelemella added the enhancement New feature or request label Mar 14, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

jacopocarlini
jacopocarlini approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@jacopocarlini jacopocarlini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

over the top ⛰️

@jacopocarlini jacopocarlini merged commit 362ede3 into main Mar 15, 2024
11 checks passed
@jacopocarlini jacopocarlini deleted the VAS-841-case-insensitive-filter branch March 15, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacopocarlini jacopocarlini jacopocarlini approved these changes

@alessio-cialini alessio-cialini Awaiting requested review from alessio-cialini alessio-cialini is a code owner

@svariant svariant Awaiting requested review from svariant svariant is a code owner

Assignees

@gioelemella gioelemella

Labels
enhancement New feature or request size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gioelemella @jacopocarlini