Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAGOPA] chore: Adjust entity rt-key #22

Merged
merged 2 commits into from
Aug 28, 2024
Merged

Conversation

cap-ang
Copy link

@cap-ang cap-ang commented Aug 27, 2024

List of Changes

  • rtKey ID validation: remove illegal characters ['/', '\', '#'] because cannot be used as entity ID and are dropped in storage phase

Motivation and Context

pagopa/pagopa-wisp-converter#81

https://stackoverflow.com/questions/57987881/azure-cosmosdb-illegal-characters-in-document-id

E.g.: when ccp is n/a the query should seek for values equal to na

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@cap-ang cap-ang added the bug Something isn't working label Aug 27, 2024
@cap-ang cap-ang requested a review from a team August 27, 2024 15:59
@cap-ang cap-ang self-assigned this Aug 27, 2024
Copy link

sonarcloud bot commented Aug 27, 2024

Copy link

@andrea-deri andrea-deri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔝

@cap-ang cap-ang merged commit bd0e906 into main Aug 28, 2024
3 checks passed
@cap-ang cap-ang deleted the PAGOPA-fix-entity-rtKey branch August 28, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants