-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only reuse launch process cache layer when test/development gem changes #195
Comments
@paketo-buildpacks/ruby-maintainers This issue has been open for a while. Does this need to be investigated further before it's workable? |
I think it's workable as is. We should re-use the launch cache layer when a development/test gem changes. |
@sophiewigmore I'm happy to take a look at implementing this, but my knowledge of the ruby ecosystem is limited, and I don't how to determine whether dev/test gems have changed. My current mental model is to expand the Does that make sense? Am I on the right track? |
@robdimsdale that seems like the right path. I'm wondering if you might be able to leverage the output of |
I'm probably not going to get to this just yet, so I'm un-assigning myself. Anyone else who is interested is welcome to pick it up! |
What happened?
Following the completion of #182, I tested out the code which installs
development
andtest
gems during the build phase. I performed a rebuild of an app withtest
gems, and I changed atest
gem (same experience fordevelopment
gem change) it caused both thebuild
andlaunch
install process to re-run.When I changed a
production
gem on a rebuild, it also caused both thebuild
andlaunch
install process to re-run.I would have only expected the relevant install process to rerun depending on the type of gem. For example, when changing a
test
gem I would've expected only thebuild
process the rerun, but thelaunch
process cache layer to be reused so that my rebuild is more performant.Build Configuration
pack
,kpack
,tekton
buildpacks plugin, etc.) are youusing? Please include a version.
pack 0.18.0
bundle-install v0.2.0
buildpack.yml
,nginx.conf
, etc.)?https://github.com/paketo-buildpacks/bundle-install/tree/main/integration/testdata/simple_app
Checklist
The text was updated successfully, but these errors were encountered: