Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

Add jammy tiny stack support to golang. #160

Merged

Conversation

robdimsdale
Copy link
Member

Summary

This PR adds the jammy tiny stack to go - which we have validated with a custom-built jammy tiny stack. There is no readily-available jammy tiny stack for CI or external consumption yet.

See also: paketo-buildpacks/go-dist#402

Signed-off-by: Frankie Gallina-Jones [email protected]

Use Cases

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Signed-off-by: Frankie Gallina-Jones <[email protected]>
@robdimsdale robdimsdale requested a review from a team as a code owner May 19, 2022 19:22
@sophiewigmore
Copy link
Member

Seems reasonable to me if you have tested this locally with success. It's also an easy-enough fix to roll back if we discovered some type of issue with it for some reason.

@sophiewigmore sophiewigmore merged commit 9179287 into paketo-buildpacks:main May 20, 2022
@loewenstein
Copy link

Wondering if go buildpacks could add support for any stack, i.e. *?

@robdimsdale
Copy link
Member Author

@loewenstein I wondered that, but the challenge is there are stacks that the go buildpacks won't work on today (e.g. io.buildpacks.stacks.windows.servercore, from https://github.com/paketo-buildpacks/procfile/blob/bc5a4da26b84cc4c37a2c623bf41c98d5fb0d47f/buildpack.toml#L44)

@robdimsdale robdimsdale deleted the add-jammy-tiny-to-go branch May 20, 2022 15:55
@loewenstein
Copy link

loewenstein commented May 20, 2022

Ok, I see. Seems like this will have to wait for buildpacks/rfcs#219 then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants