-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python apps with Javascript assets #473
Comments
Hmm. I did the following and it appears to build successfully:
@voor Is there something I'm missing that would cause this to fail? |
@voor maybe I'm missing something, but the app you linked to doesn't seem to have any python code - it seems mostly typescript/JS with a bit of HTML. Do you have a link to a different Python app that wraps this app? If not, maybe we could move this issue to the https://github.com/paketo-buildpacks/web-servers repo? |
I think moving the issue makes sense. My understanding was that this was a JavaScript web app that had a dependency that required Python to build. |
(Referring to deleted comments) Yes, it was because SASS was being built with Python involved, turns out that is not the case, apologies for adding confusion to this issue. Deleted those comments, and will mention that Python apps needing JavaScript dependencies is something fairly common. |
@voor no problem - thanks for clarifying 😄 This issue is probably best to stay where it is as a placeholder for Python apps with Javascript. I would suggest you open an issue at https://github.com/paketo-buildpacks/web-servers/issues (or https://github.com/paketo-buildpacks/nodejs) but given you've deleted your comments I'm going to assume you've got things working. |
We had a conversation in slack where a user was trying to build a python app that also had Javascript assets.
There is no built-in order group to support this, and even with custom order groups (i.e.
pack build --buildpack=...
) it still requires the buildplan buildpack to satisfy the various provides/requires.This is a use-case that we should support - similar to how the Ruby buildpack allows for Javascript assets.
The text was updated successfully, but these errors were encountered: