RFC 0019: Allow RACK_ENV to be overridden at build time #281
Labels
Comments
aramprice
added a commit
to aramprice/rackup
that referenced
this issue
Dec 21, 2022
The rack environment is hardcoded to the value `RACK_ENV=production` which appears to be a conflation of setting an ENV variable, and passing the value value via the `--env` flag to `rackup`. This commit makes two changes: 1. The value passed to the flag `--env` is now `production`, not `RACK_ENV=production`, and changes to the associated tests. 2. The value `production`, while still hard-coded, is interpolated into the process args. This should make it easier to make the value dynamic in the future. See paketo-buildpacks#281 Addresses paketo-buildpacks#355
aramprice
added a commit
to aramprice/rackup
that referenced
this issue
Dec 21, 2022
The rack environment is hard-coded to the value `RACK_ENV=production` which appears to be a conflation of setting an ENV variable, and passing the value value via the `--env` flag to `rackup`. This commit makes two changes: 1. The value passed to the flag `--env` is now `production`, not `RACK_ENV=production`, and changes to the associated tests. 2. The value `production`, while still hard-coded, is interpolated into the process args. This should make it easier to make the value dynamic in the future. See paketo-buildpacks#281 Addresses paketo-buildpacks#355
robdimsdale
pushed a commit
that referenced
this issue
Dec 21, 2022
The rack environment is hard-coded to the value `RACK_ENV=production` which appears to be a conflation of setting an ENV variable, and passing the value value via the `--env` flag to `rackup`. This commit makes two changes: 1. The value passed to the flag `--env` is now `production`, not `RACK_ENV=production`, and changes to the associated tests. 2. The value `production`, while still hard-coded, is interpolated into the process args. This should make it easier to make the value dynamic in the future. See #281 Addresses #355
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Paketo RFC 0019 states that users should be able to override environment variables that the buildpacks set, if they're environment variables commonly used in the language ecosystem.
In this buildpack, the build process sets
RACK_ENVin a way that ignores any user-provided value for the environment variable. This locks users into configuration that may not work for their app. For instance, to build https://github.com/pglombardo/PasswordPusher without an external DB,RACK_ENVmust be set toprivate.If it's possible for the buildpack to function while respecting that environment variable, it should do so.
The text was updated successfully, but these errors were encountered: