You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Several of our handlers require a small slice of what is available on InvocationHandler:
TracingInvocationEventHandler only uses java.reflect.Method.getName() for operation names
MetricsInvocationEventHandler uses getStartTimeNanos() and getMethod()
CompositeInvocationEventHandler uses no values from InvocationContnext, only a array of contexts.
What did you want to happen?
We should consider loosening InvocationEventHandler generic to Object from InvocationContext. CompositeInvocationEventHandler may implement InvocationEventHandler<Object[]> and avoid copying argument arrays, additional System.nanoTime calls, etc.
The text was updated successfully, but these errors were encountered:
carterkozak
changed the title
Consider loosening InvocationEventHanndler generic to Object
Consider loosening InvocationEventHandler generic to Object
Sep 10, 2019
What happened?
Several of our handlers require a small slice of what is available on InvocationHandler:
TracingInvocationEventHandler
only usesjava.reflect.Method.getName()
for operation namesMetricsInvocationEventHandler
usesgetStartTimeNanos()
andgetMethod()
CompositeInvocationEventHandler
uses no values fromInvocationContnext
, only a array of contexts.What did you want to happen?
We should consider loosening InvocationEventHandler generic to Object from InvocationContext.
CompositeInvocationEventHandler
may implementInvocationEventHandler<Object[]>
and avoid copying argument arrays, additional System.nanoTime calls, etc.The text was updated successfully, but these errors were encountered: