Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instrumented methods returning Futures #674

Open
schlosna opened this issue Mar 13, 2020 · 1 comment
Open

Improve instrumented methods returning Futures #674

schlosna opened this issue Mar 13, 2020 · 1 comment

Comments

@schlosna
Copy link
Contributor

What happened?

Instrumenting methods that return Future, ListenableFuture, or CompletableFuture provide somewhat misleading metrics as it is simply the time to return the future itself, not for the future to complete. A common case is Conjure’s async endpoints that return ListenableFutures

What did you want to happen?

We may want to consider tracking success/failure via completion of the future similar to https://github.com/palantir/tracing-java/blob/af0c1272342876fc435d5f12a59b8295fe066069/tracing/src/main/java/com/palantir/tracing/Tracers.java#L194-L238

@schlosna
Copy link
Contributor Author

@felixdesouza recently pushed similar changes to atlasdb in palantir/atlasdb#4661 specifically TaggedMetricsInvocationEventHandler

Also linking @ellisjoe 's unmerged PR #181 from a while back.

@felixdesouza and @carterkozak curious if this is something you have cycles to push over the finish line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant