Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/minor changes #106

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix/minor changes #106

wants to merge 3 commits into from

Conversation

jernsting
Copy link
Collaborator

I updated the parts where I changed the original repo contents in the setup py and readme back to comply with your repo.

I'd suggest adding the package to pypi in order to make this content usable for other packages. For example I would use it as dependency of https://github.com/wwu-mmll/photonai_graph. To clarify: PyPi does not allow mixed install setup.py files, all required packages have to be on pypi.

@@ -1,6 +1,4 @@
[![Python application](https://github.com/jernsting/GEM/actions/workflows/lint_and_test.yml/badge.svg)](https://github.com/jernsting/GEM/actions/workflows/lint_and_test.yml)
[![Coverage Status](https://coveralls.io/repos/github/jernsting/GEM/badge.svg?branch=master)](https://coveralls.io/github/jernsting/GEM?branch=master)
[![Quality Gate Status](https://sonarcloud.io/api/project_badges/measure?project=jernsting_GEM&metric=alert_status)](https://sonarcloud.io/summary/new_code?id=jernsting_GEM)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I you'd like Coverage and Quality Gate Status badges, you need to add the project to https://coveralls.io and https://sonarcloud.io/ (free for open source projects).

For coveralls you also need to setup a repository secret.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant