Add AboutApplicatives koan #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zip embedded values with embedded functions
Co-authored-by: Alexander Bandukwala <[email protected]>
Co-authored-by: Alexander Bandukwala <[email protected]>
Co-authored-by: Alexander Bandukwala <[email protected]>
7h3kk1d
reviewed
May 8, 2023
7h3kk1d
reviewed
May 8, 2023
| assertThat(right("World!").zip(right(getStringLength)), equalTo(__)); | ||
| assertThat(Either.<String, String>left("whoops").zip(right(getStringLength)), equalTo(left(__))); | ||
|
|
||
| // Moving on to LambdaIterables, where "zipping" is more obvious |
There was a problem hiding this comment.
We might want to point out that LambdaIterable is a specific choice in terms of how to implement Zip for iterables. It could be pairwise or cross-product. Alternatively, it might be worth putting it in a separate "test" to make that explicit.
There was a problem hiding this comment.
Added a comment about that possible alternative in 5d1d6da.
7h3kk1d
reviewed
May 8, 2023
src/test/java/com/jnape/palatable/lambdakoans/AboutApplicatives.java
Outdated
Show resolved
Hide resolved
7h3kk1d
reviewed
May 8, 2023
src/test/java/com/jnape/palatable/lambdakoans/AboutApplicatives.java
Outdated
Show resolved
Hide resolved
7h3kk1d
reviewed
May 8, 2023
|
Thanks for the contribution! From a pedagogical standpoint, I wonder if it makes sense to introduce |
- reorder functionIsApplicative - add assertion - change type signature - add timeout for applicativeRepresentsParallelism - add comments
t-rutten
force-pushed
the
about-applicatives
branch
from
7cf4157
to
e681444
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a brief demonstration of applicatives. I'm happy to include additional patterns reviewers may suggest.
@7h3kk1d was very helpful in pulling this together.