Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable mypy strict mode #429

Open
7 of 13 tasks
rnestler opened this issue Dec 20, 2022 · 0 comments
Open
7 of 13 tasks

Enable mypy strict mode #429

rnestler opened this issue Dec 20, 2022 · 0 comments

Comments

@rnestler
Copy link
Contributor

rnestler commented Dec 20, 2022 •
edited
Loading

Following up on #384 it would be good to track the progress towards mypy --strict mode. Strict mode is important to verify, that the type hints are correct, especially for a project which advertises itself as typed with the py.typed marker.

  • disallow_subclassing_any = true
  • disallow_untyped_calls = true
  • disallow_untyped_defs = true
  • disallow_incomplete_defs = true
  • check_untyped_defs = true
  • disallow_untyped_decorators = true
  • no_implicit_optional = true (Enable no_implicit_optional mypy check and fix issue #430)
  • warn_redundant_casts = true
  • warn_unused_ignores = true
  • warn_return_any = true
  • no_implicit_reexport = true
  • strict_equality = true
  • strict_concatenate = true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rnestler