TYP: NDFrame.__round__ #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are probably a few more cases where we could use Self or remove the method from NDFrame when DataFrame/Series both explicitly declare the method (typically with more precise dtype-aware version in Series). |
twoertwein
commented
Oct 6, 2023
| @@ -74,19 +74,16 @@ class NDFrame(indexing.IndexingMixin): | |||
| def ndim(self) -> int: ... | |||
| @property | |||
| def size(self) -> int: ... | |||
| def swapaxes( | |||
There was a problem hiding this comment.
Is deprecated since 2.1
Dr-Irv
approved these changes
Oct 6, 2023
There was a problem hiding this comment.
thanks @twoertwein . Ideally, we'd have tests for the other things you changed, but that's a lot of work, so I'm OK with just putting these kinds of improvements in there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valuetoinsertofDataFramehas incompatible typeNDFrame#791 (Replace xxxx with the Github issue number)assert_type()to assert the type of any return value