Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pandas 2.0 removals in testing and clipboard #933

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

hamdanal
Copy link
Contributor

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same issue on pytest.warns(). Also one other thing I saw

pandas-stubs/_testing/__init__.pyi Outdated Show resolved Hide resolved
tests/test_plotting.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double checked some of the changes vs. the 2.2.2 source, and caught a few more things.

pandas-stubs/_testing/__init__.pyi Outdated Show resolved Hide resolved
pandas-stubs/_testing/__init__.pyi Outdated Show resolved Hide resolved
@hamdanal
Copy link
Contributor Author

@Dr-Irv thanks for the review. I went ahead and fixed all the functions in this module.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hamdanal

@adrian17
Copy link

Hey, we just stumbled upon this PR, as the pandas.testing APIs are not typed correctly without it. Are there any plans on getting it merged?

@Dr-Irv Dr-Irv merged commit ce546ff into pandas-dev:main Aug 20, 2024
13 checks passed
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 20, 2024

Hey, we just stumbled upon this PR, as the pandas.testing APIs are not typed correctly without it. Are there any plans on getting it merged?

Thanks. Not sure why I forgot to merge!

@hamdanal hamdanal deleted the pandas2-removals-others branch October 26, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants