Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tuple-valued params in read_sql[_query] #997

Merged

Conversation

sh-at-cs
Copy link
Contributor

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Sep 11, 2024

You need to run black on your changed files, or follow the instructions at https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md to set up your environment and install the pre-commit checks.

@sh-at-cs sh-at-cs force-pushed the fix-gh-996-read-sql-query-tuple-param-values branch from 488bab4 to db3f61d Compare September 12, 2024 07:13
@sh-at-cs sh-at-cs force-pushed the fix-gh-996-read-sql-query-tuple-param-values branch from db3f61d to 39a96fb Compare September 12, 2024 07:16
@sh-at-cs
Copy link
Contributor Author

Sorry, I ran my system black on it which had a different version and hence slightly different formatting. Should be fixed now - at least pre-commit runs without errors.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sh-at-cs

@Dr-Irv Dr-Irv merged commit 708c8aa into pandas-dev:main Sep 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

read_sql_query should support tuples as params dict values
2 participants