Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent treatment of labels with leading (trailing) spaces #32

Open
jbusecke opened this issue Mar 22, 2024 · 0 comments
Open

Consistent treatment of labels with leading (trailing) spaces #32

jbusecke opened this issue Mar 22, 2024 · 0 comments

Comments

@jbusecke
Copy link
Contributor

jbusecke commented Mar 22, 2024

I just discovered that when you specify recipe labels with leading spaces (run: some_recipe_id), the recipe will get picked up by the action (it tries to run it), but will fail due to the constucted jobname still containing spaces (which dataflow hates).

We should make this behavior consistent by doing one of the below:

  • Error out earlier in the action (with helpful error message) if the label based id contains spaces
  • Or remove spaces automatically as part of the name generation.

I guess if we are implementing one or the other we want to take care of trailing spaces too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant