This repository has been archived by the owner on Dec 7, 2023. It is now read-only.
Add recipe and pattern hashes to RecipeRun table #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 29, 2022
|
As noted in pangeo-forge/user-stories#3 (comment), this may no longer be necessary. |
|
I believe we can close this, as it has been superseded by pangeo-forge/pangeo-forge-recipes#359, which stores the same information in the target dataset metadata, rather than the database. This avoids needing to run a database migration here. I will close now, since I was the one who opened this, but certainly open to further discussion regarding re-opening, if others feel this is better stored in the database. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This WIP follows on pangeo-forge/pangeo-forge-recipes#349 to add recipe and pattern hashes to the RecipeRun table.