-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MUR SST Kerchunk recipe #647
Comments
This issue should probably be on pangeo-forge/staged-recipes, but I've been working on a new branch this week for what I thought would be a relatively straightforward change to the existing MUR SST recipe branch and found that the Current recipe: identical_dims = ['lat', 'lon']
selected_vars = ['analysed_sst', 'analysis_error', 'mask', 'sea_ice_fraction']
recipe = (
beam.Create(pattern.items())
| OpenWithKerchunk(
remote_protocol='s3' if selected_rel == S3_REL else 'https',
file_type=pattern.file_type,
# inline_threshold=10000,
storage_options=pattern.fsspec_open_kwargs
)
| FilterVars(
keep={*pattern.concat_dims, *identical_dims, *selected_vars}
)
| WriteCombinedReference(
store_name='mursst',
concat_dims=pattern.concat_dims,
identical_dims=identical_dims,
)
) The key line here is Without inline:
With inline:
I'm not entirely sure what the best practice is to handle this scenario or how to properly detect that Separately, the resulting metadata isn't |
I was doing it wrong, forgot that I needed to forward along the storage_options to remote_options when creating a reference fs. |
I was able to run this recipe locally with the scripts/changes/tests outlined in this gist: https://gist.github.com/abarciauskas-bgse/cff4c77ea841601773d087bc6b45122b A few questions / next steps:
|
Nice 🥳 Can you run it locally full on without
I think all these custom ones have already been merged or are about to by Raphael. Let me review what needs to change and comment/suggest on your new PR when you have it up
I think forcing the lookup to happen on the workers instead of the host is ideal yes
Yeah, let me run this later today as a |
No description provided.
The text was updated successfully, but these errors were encountered: