Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for feedstocks with preprocessor functions #31

Open
cisaacstern opened this issue Sep 19, 2022 · 0 comments
Open

Add testing for feedstocks with preprocessor functions #31

cisaacstern opened this issue Sep 19, 2022 · 0 comments

Comments

@cisaacstern
Copy link
Member

Preprocessor functions in feedstocks can cause serialization issues, e.g. pangeo-forge/staged-recipes#183 (comment).

We should add testing against a feedstock that uses a preprocessor function, to catch these issues early.

To do this, I suggest we create a branch on our test feedstock https://github.com/pforgetest/gpcp-from-gcs-feedstock that implements a basic (even no-op) preprocessor, and then parametrize test_bake with that branch here:

"https://github.com/pforgetest/gpcp-from-gcs-feedstock.git",
"--ref",
"4f41e02512b2078c8bdb286368a1a9d878b5cec2",

@cisaacstern cisaacstern changed the title Add testing of feedstock with preprocessor function Add testing for feedstocks with preprocessor functions Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant