Add passthrough for storage cls args #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
==========================================
+ Coverage 96.46% 96.48% +0.02%
==========================================
Files 15 15
Lines 509 512 +3
==========================================
+ Hits 491 494 +3
Misses 18 18 ☔ View full report in Codecov by Sentry. |
moradology
requested changes
Feb 13, 2024
| target_cls_args_str = ", ".join( | ||
| f"{k}={v}" for k, v in self.pangeo_forge_target_class_args.items() | ||
| ) | ||
| return base + (f", {target_cls_args_str}" if target_cls_args_str else "") + ")" |
There was a problem hiding this comment.
I think this should be equivalent and a bit terser/easier to read: f"{base}, {target_cls_args_str})"
(I think join here should produce "" if no iterations happen from items(), so the check is not necessary)
moradology
reviewed
Feb 13, 2024
Comment on lines
82
to
+85
| self.fsspec_class(**self.fsspec_args), | ||
| root_path=self.root_path.format(job_name=job_name), | ||
| fsspec_kwargs=self.fsspec_args, | ||
| **self.pangeo_forge_target_class_args, |
There was a problem hiding this comment.
Might be good to disambiguate the intents of pangeo_forge_target_class_args and fsspec_args
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pangeo-forge/pangeo-forge-recipes#630 introduces the possibility that storage classes could take args.
This PR adds the ability to passthrough such args.