Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-native-ratings shouldn't be a dependency #55

Open
geraintwhite opened this issue Feb 6, 2023 · 0 comments
Open

react-native-ratings shouldn't be a dependency #55

geraintwhite opened this issue Feb 6, 2023 · 0 comments

Comments

@geraintwhite
Copy link

Having react-native-ratings: "^6.5.0" in the dependencies and react-native-ratings: "^4.1.0" in the peer dependencies means this library uses an older version which doesn't support the latest features and props.

It would be better to omit it from dependencies and have a more flexible version like >=4, otherwise the workaround for app developers is to use the npm overrides feature with "react-native-ratings": "$react-native-ratings" to force the same version throughout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geraintwhite