Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combobox / Multiselect combobox filtering behaves unexpected #1411

Open
Sebastian-ubs opened this issue Dec 20, 2024 · 0 comments
Open

Combobox / Multiselect combobox filtering behaves unexpected #1411

Sebastian-ubs opened this issue Dec 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Sebastian-ubs
Copy link
Contributor

Describe the bug
When filtering entries in the combobox popover, the results are unexpected

  1. not sorted like the list is sorted by sort that we provided. Instead they are sorted "by priority" - whatever that means
  2. results unexpectedly include strings that do not appear in the displayed text

According to @rolfheij (in #1399) this is coming from internal Radix filter logic inside of the combobox.

✅ expected ❌ unexpected
Image Image
Image Image Image

Sorting distorted and unexpected results
Image

To Reproduce

Expected behavior
Filter only based on visual text. Space separate different search terms that all have to apply - even in a different order (this would not match right now).

Implementation Ideas

  • make sorting a function that is passed to the Command
  • add onValueChanged to the CommandInput and implement own filter logic
  • (add x button to clear filter)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant