Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Remove @polkadot/apps-config depencency #515

Merged
merged 3 commits into from
Nov 16, 2024

Conversation

michaeldev5
Copy link
Collaborator

Closes #481

@michaeldev5 michaeldev5 self-assigned this Nov 16, 2024
Copy link

codecov bot commented Nov 16, 2024

Bundle Report

Changes will increase total bundle size by 21.61kB (3.8%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sdk-cjs-esm 431.79kB 21.61kB (5.27%) ⬆️

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

Attention: Patch coverage is 92.79279% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/sdk/src/nodes/config/getNodeProvider.ts 81.81% 2 Missing ⚠️
packages/sdk/src/nodes/supported/Hydration.ts 75.00% 2 Missing ⚠️
packages/sdk/src/nodes/ParachainNode.ts 91.66% 1 Missing ⚠️
packages/sdk/src/nodes/supported/Karura.ts 66.66% 1 Missing ⚠️
packages/sdk/src/pallets/assets/assets.ts 66.66% 1 Missing ⚠️
packages/sdk/src/pallets/xcmPallet/transfer.ts 80.00% 1 Missing ⚠️
Flag Coverage Δ
visualizator-be 100.00% <ø> (ø)
xcm-analyser 98.40% <ø> (ø)
xcm-api 97.73% <ø> (ø)
xcm-router 91.90% <ø> (ø)
xcm-sdk 96.01% <92.79%> (+0.26%) ⬆️
Files with missing lines Coverage Δ
packages/sdk/src/builder/builders/Builder.ts 100.00% <100.00%> (ø)
...ges/sdk/src/builder/builders/RelayToParaBuilder.ts 100.00% <100.00%> (ø)
packages/sdk/src/nodes/config/getNodeConfig.ts 100.00% <100.00%> (ø)
packages/sdk/src/nodes/config/getNodeProviders.ts 100.00% <100.00%> (ø)
packages/sdk/src/nodes/config/getParaId.ts 100.00% <100.00%> (ø)
packages/sdk/src/nodes/config/index.ts 100.00% <100.00%> (ø)
packages/sdk/src/nodes/supported/Acala.ts 100.00% <100.00%> (ø)
...ckages/sdk/src/nodes/supported/AssetHubPolkadot.ts 98.88% <100.00%> (+<0.01%) ⬆️
packages/sdk/src/nodes/supported/Basilisk.ts 91.30% <100.00%> (ø)
packages/sdk/src/nodes/supported/BifrostKusama.ts 100.00% <100.00%> (ø)
... and 26 more

@michaeldev5 michaeldev5 marked this pull request as ready for review November 16, 2024 16:16
@michaeldev5 michaeldev5 force-pushed the fix/remove-apps-config branch 7 times, most recently from 5721e4a to 793e622 Compare November 16, 2024 22:33
@dudo50 dudo50 merged commit 896bc60 into main Nov 16, 2024
14 checks passed
@dudo50 dudo50 deleted the fix/remove-apps-config branch November 16, 2024 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove @polkadot/apps-config because it has @polkadot/api as dependency
2 participants