Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txWatch: Stabilize to version 1 #154

Merged
merged 2 commits into from
Apr 17, 2024
Merged

txWatch: Stabilize to version 1 #154

merged 2 commits into from
Apr 17, 2024

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Apr 17, 2024

This PR stabilizes the transactionWatch class of APIs.

Depends on: #153.

cc @paritytech/subxt-team @tomaka

Signed-off-by: Alexandru Vasile <[email protected]>
jsdw
jsdw previously approved these changes Apr 17, 2024
Copy link
Collaborator

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this as long as @tomaka is :)

niklasad1
niklasad1 previously approved these changes Apr 17, 2024
@lexnv lexnv dismissed stale reviews from niklasad1 and jsdw via 46ff263 April 17, 2024 14:50
@lexnv lexnv merged commit df687bf into main Apr 17, 2024
2 checks passed
@lexnv lexnv deleted the lexnv/stab-tx-watch-v1 branch April 17, 2024 14:52
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Apr 19, 2024
This PR stabilizes the txBroadcast API to version 1.

Needs from spec:
- paritytech/json-rpc-interface-spec#153 
- paritytech/json-rpc-interface-spec#154


cc @paritytech/subxt-team

---------

Signed-off-by: Alexandru Vasile <[email protected]>
@Polkadot-Forum
Copy link

This pull request has been mentioned on Polkadot Forum. There might be relevant details there:

https://forum.polkadot.network/t/paritytech-update-for-april/7646/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants