Address migration comments #2910
Conversation
tools/runtime-codegen/Cargo.toml
Outdated
| @@ -4,15 +4,16 @@ version = "0.1.0" | |||
| description = "Tool for generating bridge runtime code from metadata" | |||
| authors = ["Parity Technologies <[email protected]>"] | |||
| edition = "2021" | |||
| license = "GPL-3.0-or-later WITH Classpath-exception-2.0" | |||
| license = "GPL-3.0-only" | |||
There was a problem hiding this comment.
Should we change to "GPL-3.0-or-later WITH Classpath-exception-2.0"?
There was a problem hiding this comment.
I don't know what is the difference between GPL-3.0-only and GPL-3.0-or-later WITH Classpath-exception-2.0. I changed it just for consistency.
You mean just here to leave it GPL-3.0-or-later WITH Classpath-exception-2.0 as before ? Or to change the parity-bridges-common workspace to GPL-3.0-or-later WITH Classpath-exception-2.0 ?
There was a problem hiding this comment.
Sorry, I mean - leave the previous version : "GPL-3.0-or-later WITH Classpath-exception-2.0". The whole license stuff is explained here: https://substrate.stackexchange.com/questions/594/how-should-we-choose-a-license - Apache for pallets and other runtime stuff and GPL with classpath for client (also relay). I may be wrong, though - just think that we don't want to restrict license on already available code.
There was a problem hiding this comment.
Ok, thanks for the explanation ! Reverted the licenses to the previous version.
* Use workspace.[authors|edition] * Add repository.workspace = true * Upgrade dependencies to the polkadot-sdk versions * Upgrade async-std version * Update jsonrpsee version * cargo update * use ci-unified image
* Use workspace.[authors|edition] * Add repository.workspace = true * Upgrade dependencies to the polkadot-sdk versions * Upgrade async-std version * Update jsonrpsee version * cargo update * use ci-unified image
Related to #2538
Addressing comments from paritytech/polkadot-sdk#3859
More details in the commit titles