-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework the event system of sc-network
#1370
Commits on Sep 3, 2023
-
Rework the event system of
sc-network
This commit introduces a new concept called `NotificationService` which allows Polkadot protocols to communicate with the underlying notification protocol implementation directly, without routing events through `NetworkWorker`. This implies that each protocol has its own service which it uses to communicate with remote peers and that each `NotificationService` is unique with respect to the underlying notification protocol, meaning `NotificationService` for the transaction protocol can only be used to send and receive transaction-related notifications. The `NotificationService` concept introduces two additional benefits: * allow protocols to start using custom handshakes * allow protocols to accept/reject inbound peers Previously the validation of inbound connections was solely the responsibility of `ProtocolController`. This caused issues with light peers and `SyncingEngine` as `ProtocolController` would accept more peers than `SyncingEngine` could accept which caused peers to have differing views of their own states. `SyncingEngine` would reject excess peers but these rejections were not properly communicated to those peers causing them to assume that they were accepted. With `NotificationService`, the local handshake is not sent to remote peer if peer is rejected which allows it to detect that it was rejected. This commit also deprecates the use of `NetworkEventStream` for all notification-related events and going forward only DHT events are provided through `NetworkEventStream`. If protocols wish to follow each other's events, they must introduce additional abtractions, as is done for GRANDPA and transactions protocols by following the syncing protocol through `SyncEventStream`. Fixes #512 Fixes #514 Fixes #515 Fixes #554 Fixes #556 Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f643843 - Browse repository at this point
Copy the full SHA f643843View commit details -
Configuration menu - View commit details
-
Copy full SHA for 026466c - Browse repository at this point
Copy the full SHA 026466cView commit details
Commits on Sep 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 229197e - Browse repository at this point
Copy the full SHA 229197eView commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 6d995a0 - Browse repository at this point
Copy the full SHA 6d995a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 208fe22 - Browse repository at this point
Copy the full SHA 208fe22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00611e0 - Browse repository at this point
Copy the full SHA 00611e0View commit details
Commits on Sep 5, 2023
-
Update substrate/client/network/src/service/traits.rs
Co-authored-by: Alexandru Vasile <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b6174e3 - Browse repository at this point
Copy the full SHA b6174e3View commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 4fe313e - Browse repository at this point
Copy the full SHA 4fe313eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 120f429 - Browse repository at this point
Copy the full SHA 120f429View commit details
Commits on Sep 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fa7156b - Browse repository at this point
Copy the full SHA fa7156bView commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for e1acf57 - Browse repository at this point
Copy the full SHA e1acf57View commit details
Commits on Sep 14, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for d5a8374 - Browse repository at this point
Copy the full SHA d5a8374View commit details
Commits on Sep 22, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for d178270 - Browse repository at this point
Copy the full SHA d178270View commit details
Commits on Sep 23, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for c6b10d5 - Browse repository at this point
Copy the full SHA c6b10d5View commit details
Commits on Sep 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 2d4bdda - Browse repository at this point
Copy the full SHA 2d4bddaView commit details
Commits on Sep 26, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for b074c57 - Browse repository at this point
Copy the full SHA b074c57View commit details
Commits on Sep 28, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 910a737 - Browse repository at this point
Copy the full SHA 910a737View commit details
Commits on Oct 1, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 3aa962c - Browse repository at this point
Copy the full SHA 3aa962cView commit details
Commits on Oct 16, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for beee591 - Browse repository at this point
Copy the full SHA beee591View commit details
Commits on Oct 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f4286da - Browse repository at this point
Copy the full SHA f4286daView commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for a2bf29d - Browse repository at this point
Copy the full SHA a2bf29dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff10bfb - Browse repository at this point
Copy the full SHA ff10bfbView commit details
Commits on Oct 20, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 1fab0f1 - Browse repository at this point
Copy the full SHA 1fab0f1View commit details
Commits on Nov 1, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for e2d6d22 - Browse repository at this point
Copy the full SHA e2d6d22View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6451147 - Browse repository at this point
Copy the full SHA 6451147View commit details
Commits on Nov 2, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for ede7ff0 - Browse repository at this point
Copy the full SHA ede7ff0View commit details
Commits on Nov 4, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 09be0b9 - Browse repository at this point
Copy the full SHA 09be0b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd3a6ce - Browse repository at this point
Copy the full SHA fd3a6ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for bc9d6cf - Browse repository at this point
Copy the full SHA bc9d6cfView commit details
Commits on Nov 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for aa78cf6 - Browse repository at this point
Copy the full SHA aa78cf6View commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for cc2b3cf - Browse repository at this point
Copy the full SHA cc2b3cfView commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 81b5997 - Browse repository at this point
Copy the full SHA 81b5997View commit details
Commits on Nov 8, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 9d24a55 - Browse repository at this point
Copy the full SHA 9d24a55View commit details
Commits on Nov 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 11b0dac - Browse repository at this point
Copy the full SHA 11b0dacView commit details
Commits on Nov 13, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 2e52080 - Browse repository at this point
Copy the full SHA 2e52080View commit details
Commits on Nov 16, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 6515510 - Browse repository at this point
Copy the full SHA 6515510View commit details -
Configuration menu - View commit details
-
Copy full SHA for 633f481 - Browse repository at this point
Copy the full SHA 633f481View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8dec276 - Browse repository at this point
Copy the full SHA 8dec276View commit details
Commits on Nov 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6dfef05 - Browse repository at this point
Copy the full SHA 6dfef05View commit details
Commits on Nov 20, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 6da99b3 - Browse repository at this point
Copy the full SHA 6da99b3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65ece16 - Browse repository at this point
Copy the full SHA 65ece16View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7770477 - Browse repository at this point
Copy the full SHA 7770477View commit details -
Configuration menu - View commit details
-
Copy full SHA for eeab2fd - Browse repository at this point
Copy the full SHA eeab2fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5049ade - Browse repository at this point
Copy the full SHA 5049adeView commit details
Commits on Nov 21, 2023
-
Prioritize validation events over other events
GRANDPA and transactions follow syncing protocol for peers while they're still required to validate inbound peers. Peer might be accepted over GRANDPA and after `ProtocolController` has accepted the peer, the peer is sent to the protocol for validation. While it was being validated, syncing protocol may have disconnected from the peer, instructing GRANDPA to disconnect as well. If the validation result from GRANDPA is not processed before the disconnection request is received from
Configuration menu - View commit details
-
Copy full SHA for befd2d9 - Browse repository at this point
Copy the full SHA befd2d9View commit details
Commits on Nov 22, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cd94277 - Browse repository at this point
Copy the full SHA cd94277View commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 0e140bd - Browse repository at this point
Copy the full SHA 0e140bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for baf44b2 - Browse repository at this point
Copy the full SHA baf44b2View commit details
Commits on Nov 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for ac76424 - Browse repository at this point
Copy the full SHA ac76424View commit details
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 20395c6 - Browse repository at this point
Copy the full SHA 20395c6View commit details
Commits on Nov 27, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 3273e32 - Browse repository at this point
Copy the full SHA 3273e32View commit details -
Configuration menu - View commit details
-
Copy full SHA for e791de2 - Browse repository at this point
Copy the full SHA e791de2View commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 32c0c5f - Browse repository at this point
Copy the full SHA 32c0c5fView commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 1ce77bd - Browse repository at this point
Copy the full SHA 1ce77bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 691f4c8 - Browse repository at this point
Copy the full SHA 691f4c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b04d65d - Browse repository at this point
Copy the full SHA b04d65dView commit details
Commits on Nov 28, 2023
-
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 0b2e718 - Browse repository at this point
Copy the full SHA 0b2e718View commit details -
Merge remote-tracking branch 'origin/master' into altonen-rework-sc-n…
…etwork-event-system
Configuration menu - View commit details
-
Copy full SHA for 76bb0be - Browse repository at this point
Copy the full SHA 76bb0beView commit details