Fix XcmPaymentApi::query_weight_to_asset_fee version conversion

[franciscoaguirre]

The query_weight_to_asset_fee function was trying to convert versions by using try_as, this function doesn't convert from a versioned to a concrete type.
This would cause all calls with a lower version to fail.

The correct function to use is the good old try_into.
Now those calls work :)

[franciscoaguirre]

bot fmt

[command-bot]

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7748401 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 7-7b71fbec-42d5-4285-ae51-a1bb4e834e9f to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7748401 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7748401/artifacts/download.

[bkontur]

lgmt modulo @franciscoaguirre could you please check #6467 - it could simplify

[franciscoaguirre]

/cmd fmt

[github-actions]

Command "fmt" has started 🚀 See logs here

[github-actions]

Command "fmt" has finished ✅ See logs here

[franciscoaguirre]

@bkontur I deduplicated the test and extended it to call quote_price_tokens_for_exact_tokens. Please take a look again.

[franciscoaguirre]

/cmd help

[github-actions]

Command "help" has started 🚀 See logs here

[github-actions]

Command "help" has failed ❌! See logs here

[franciscoaguirre]

/cmd --help

[github-actions]

Command help:

usage: /cmd  [--help] [--quiet] [--clean] [--image IMAGE]
             {bench,fmt,update-ui,prdoc} ...

A command runner for polkadot-sdk repo

positional arguments:
  {bench,fmt,update-ui,prdoc}
                        a command to run
    bench               Runs benchmarks
    fmt                 Formats code (cargo +nightly-VERSION fmt) and configs
                        (taplo format)
    update-ui           Updates UI tests
    prdoc               Generates PR documentation

options:
  --help                help for help if you need some help
  --quiet               Won't print start/end/failed messages in PR
  --clean               Clean up the previous bot's & author's comments in PR
  --image IMAGE         Override docker image '--image
                        docker.io/paritytech/ci-unified:latest'

### Command 'bench'
usage: /cmd bench [-h] [--quiet] [--clean] [--image IMAGE]
                  [--runtime [{dev,westend,rococo,asset-hub-westend,asset-hub-rococo,bridge-hub-rococo,bridge-hub-westend,collectives-westend,contracts-rococo,coretime-rococo,coretime-westend,glutton-westend,people-rococo,people-westend} ...]]
                  [--pallet [PALLET ...]] [--fail-fast]

options:
  -h, --help            show this help message and exit
  --quiet               Won't print start/end/failed messages in PR
  --clean               Clean up the previous bot's & author's comments in PR
  --image IMAGE         Override docker image '--image
                        docker.io/paritytech/ci-unified:latest'
  --runtime [{dev,westend,rococo,asset-hub-westend,asset-hub-rococo,bridge-hub-rococo,bridge-hub-westend,collectives-westend,contracts-rococo,coretime-rococo,coretime-westend,glutton-westend,people-rococo,people-westend} ...]
                        Runtime(s) space separated
  --pallet [PALLET ...]
                        Pallet(s) space separated
  --fail-fast           Fail fast on first failed benchmark

**Examples**:
 Runs all benchmarks
 /cmd bench

 Runs benchmarks for pallet_balances and pallet_multisig for all runtimes which have these pallets. **--quiet** makes it to output nothing to PR but reactions
 /cmd bench --pallet pallet_balances pallet_xcm_benchmarks::generic --quiet

 Runs bench for all pallets for westend runtime and fails fast on first failed benchmark
 /cmd bench --runtime westend --fail-fast

 Does not output anything and cleans up the previous bot's & author command triggering comments in PR
 /cmd bench --runtime westend rococo --pallet pallet_balances pallet_multisig --quiet --clean


### Command 'fmt'
usage: /cmd fmt [-h] [--quiet] [--clean] [--image IMAGE]

options:
  -h, --help     show this help message and exit
  --quiet        Won't print start/end/failed messages in PR
  --clean        Clean up the previous bot's & author's comments in PR
  --image IMAGE  Override docker image '--image docker.io/paritytech/ci-
                 unified:latest'


### Command 'update-ui'
usage: /cmd update-ui [-h] [--quiet] [--clean] [--image IMAGE]

options:
  -h, --help     show this help message and exit
  --quiet        Won't print start/end/failed messages in PR
  --clean        Clean up the previous bot's & author's comments in PR
  --image IMAGE  Override docker image '--image docker.io/paritytech/ci-
                 unified:latest'


### Command 'prdoc'
usage: /cmd prdoc [-h] [--pr PR]
                  [--audience [{runtime_dev,runtime_user,node_dev,node_operator} ...]]
                  [--bump {patch,minor,major,silent,ignore,no_change}]
                  [--force]

options:
  -h, --help            show this help message and exit
  --pr PR               The PR number to generate the PrDoc for.
  --audience [{runtime_dev,runtime_user,node_dev,node_operator} ...]
                        The audience of whom the changes may concern. Example:
                        --audience runtime_dev node_dev
  --bump {patch,minor,major,silent,ignore,no_change}
                        A default bump level for all crates. Example: --bump
                        patch
  --force               Whether to overwrite any existing PrDoc.

[bkontur]

@bkontur I deduplicated the test and extended it to call quote_price_tokens_for_exact_tokens. Please take a look again.

very nice, I am just thinking now, that we could/should split xcm_payment_api_works to two test-cases:

• xcm_payment_api_with_native_token_works
• xcm_payment_api_with_pools_works

or something like that, because not every runtime has the pools, e.g. coretime/people/relaychains...

[franciscoaguirre]

Right now it's in assets/test-utils/. If I divide it in two I can put them in test-utils and use the pools test only in asset hubs

[franciscoaguirre]

/cmd fmt

[github-actions]

Command "fmt" has started 🚀 See logs here

[github-actions]

Command "fmt" has finished ✅ See logs here

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12031120784
Failed job name: fmt

[x3c41a]

Isn't Cargo.lock supposed to be changed automatically?

[franciscoaguirre]

It was changed automatically. All the added lines are because I changed dependencies in various crates' Cargo.tomls

[paritytech-cmd-bot-polkadot-sdk]

Created backport PR for stable2407:

• [stable2407] Backport #6459 #6663 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6459-to-stable2407
git worktree add --checkout .worktree/backport-6459-to-stable2407 backport-6459-to-stable2407
cd .worktree/backport-6459-to-stable2407
git reset --hard HEAD^
git cherry-pick -x 139691b17c66aa074d2b4ae935158d4296068f72
git push --force-with-lease

[paritytech-cmd-bot-polkadot-sdk]

Created backport PR for stable2409:

• [stable2409] Backport #6459 #6664 with remaining conflicts!

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6459-to-stable2409
git worktree add --checkout .worktree/backport-6459-to-stable2409 backport-6459-to-stable2409
cd .worktree/backport-6459-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 139691b17c66aa074d2b4ae935158d4296068f72
git push --force-with-lease