Commits on Nov 26, 2024

1. rpc server: fix subscription id_provider being reset to default one. (#… …

   …6588)
   
   # Description
   
   The PR ensures that the id_provider variable is cloned instead of taken,
   which can help prevent issues related id provider being reset to the
   default.
   
   In [a test in
   moonbeam](https://github.com/moonbeam-foundation/moonbeam/blob/c6d07d703dfcdd94cc311fa83b553071b7d433ff/test/suites/dev/moonbase/test-subscription/test-subscription.ts#L20-L31)
   we found that the id_provider is being reset somehow and changed to the
   default one. Changing .take() to .clone() would fix the issue.
   
   
   # Checklist
   
   * [x] My PR includes a detailed description as outlined in the
   "Description" and its two subsections above.
   * [ ] My PR follows the [labeling requirements](
   
   https://github.com/paritytech/polkadot-sdk/blob/master/docs/contributor/CONTRIBUTING.md#Process
   ) of this project (at minimum one label for `T` required)
   * External contributors: ask maintainers to put the right label on your
   PR.
   * [ ] I have made corresponding changes to the documentation (if
   applicable)
   * [ ] I have added tests that prove my fix is effective or that my
   feature works (if applicable)
   
   ---------
   
   Co-authored-by: Niklas Adolfsson <[email protected]>

   

   TarekkMA and niklasad1 committed Nov 26, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 6246338
   • Browse repository at this point

   Copy the full SHA

   6246338 View commit details

   Browse the repository at this point in the history