This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Rework the event system of sc-network
#14197
Open
altonen
wants to merge
50
commits into
master
Choose a base branch
from
notification-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on May 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cb99f5c - Browse repository at this point
Copy the full SHA cb99f5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 471616a - Browse repository at this point
Copy the full SHA 471616aView commit details -
Configuration menu - View commit details
-
Copy full SHA for c456edd - Browse repository at this point
Copy the full SHA c456eddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5593a53 - Browse repository at this point
Copy the full SHA 5593a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for 22cd46c - Browse repository at this point
Copy the full SHA 22cd46cView commit details -
Configuration menu - View commit details
-
Copy full SHA for b42b901 - Browse repository at this point
Copy the full SHA b42b901View commit details -
Poll commands from protocols in
Notifications
Substream open/close functionality is not supported so they're left as `todo!()s`. Remove `SendNotification` command as sending notifications is now supported by using the installed notification sink received in `NotificationStreamOpened` event.
Configuration menu - View commit details
-
Copy full SHA for 9685625 - Browse repository at this point
Copy the full SHA 9685625View commit details -
Configuration menu - View commit details
-
Copy full SHA for b93cf90 - Browse repository at this point
Copy the full SHA b93cf90View commit details -
Send
NotificationEvent
s fromNotifications
The role should not be part of `NotificationStreamOpened` as `Notifications` has no knowledge of that and the protocols that are interested in that information should query it from `Peerset` (when the support for that is added)
Configuration menu - View commit details
-
Copy full SHA for 8cc85c6 - Browse repository at this point
Copy the full SHA 8cc85c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4f9090 - Browse repository at this point
Copy the full SHA f4f9090View commit details -
Configuration menu - View commit details
-
Copy full SHA for 796f826 - Browse repository at this point
Copy the full SHA 796f826View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00a093a - Browse repository at this point
Copy the full SHA 00a093aView commit details -
Configuration menu - View commit details
-
Copy full SHA for a3746dc - Browse repository at this point
Copy the full SHA a3746dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 15d093b - Browse repository at this point
Copy the full SHA 15d093bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 513ca87 - Browse repository at this point
Copy the full SHA 513ca87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2e9da9c - Browse repository at this point
Copy the full SHA 2e9da9cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fd9a08 - Browse repository at this point
Copy the full SHA 1fd9a08View commit details
Commits on May 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 94e1e79 - Browse repository at this point
Copy the full SHA 94e1e79View commit details -
Apply suggestions from code review
Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b19ccb8 - Browse repository at this point
Copy the full SHA b19ccb8View commit details
Commits on May 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 37db9f6 - Browse repository at this point
Copy the full SHA 37db9f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e2ad89 - Browse repository at this point
Copy the full SHA 4e2ad89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3441cfa - Browse repository at this point
Copy the full SHA 3441cfaView commit details -
Apply suggestions from code review
Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 182fdc7 - Browse repository at this point
Copy the full SHA 182fdc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 440402c - Browse repository at this point
Copy the full SHA 440402cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d2250 - Browse repository at this point
Copy the full SHA 96d2250View commit details
Commits on Jun 5, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fd41d7d - Browse repository at this point
Copy the full SHA fd41d7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea56743 - Browse repository at this point
Copy the full SHA ea56743View commit details
Commits on Jun 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1097738 - Browse repository at this point
Copy the full SHA 1097738View commit details -
Configuration menu - View commit details
-
Copy full SHA for 140b830 - Browse repository at this point
Copy the full SHA 140b830View commit details
Commits on Jun 14, 2023
-
The previous implementation of exposing `NotificationsSink` to the protocol was too leaky. Introduce new `MessageSink` abstraction which provides a clean send interface and internally handles notification sink replaces so the protocol doesn't have replace the sink when it's replaced.
Configuration menu - View commit details
-
Copy full SHA for 711761d - Browse repository at this point
Copy the full SHA 711761dView commit details
Commits on Jul 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 294fd49 - Browse repository at this point
Copy the full SHA 294fd49View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b9368f8 - Browse repository at this point
Copy the full SHA b9368f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 258fd5a - Browse repository at this point
Copy the full SHA 258fd5aView commit details
Commits on Jul 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1132424 - Browse repository at this point
Copy the full SHA 1132424View commit details -
Don't return
Result
forsend_sync_notification()
The original API ignores the case where the peer doesn't exist
Configuration menu - View commit details
-
Copy full SHA for 4b02a3d - Browse repository at this point
Copy the full SHA 4b02a3dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c3ff587 - Browse repository at this point
Copy the full SHA c3ff587View commit details
Commits on Aug 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for b8e2fcc - Browse repository at this point
Copy the full SHA b8e2fccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1b84a72 - Browse repository at this point
Copy the full SHA 1b84a72View commit details
Commits on Aug 4, 2023
-
Previously the peer role was decoded in `Protocol` but now that the protocol is directly communicating with `Notifications`, the handshake decoding is no longer done on behalf of the protocol. Introduce a new function `NetworkPeers::peer_role()` which allows the protocol to fetch the peer role. The function takes the received handshake (which should contain the role) and in case the handshake doesn't contain the protocol, it's fetched from `PeerStore`. If the peer role cannot be determined, `None` is returned, indicating to the protocol that it should discard the peer.
Configuration menu - View commit details
-
Copy full SHA for aad966a - Browse repository at this point
Copy the full SHA aad966aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 295a6a7 - Browse repository at this point
Copy the full SHA 295a6a7View commit details
Commits on Aug 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for fe8eeed - Browse repository at this point
Copy the full SHA fe8eeedView commit details -
Configuration menu - View commit details
-
Copy full SHA for ccb3beb - Browse repository at this point
Copy the full SHA ccb3bebView commit details
Commits on Aug 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for d38b53b - Browse repository at this point
Copy the full SHA d38b53bView commit details
Commits on Aug 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for a84000f - Browse repository at this point
Copy the full SHA a84000fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 92da646 - Browse repository at this point
Copy the full SHA 92da646View commit details
Commits on Aug 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 18d948e - Browse repository at this point
Copy the full SHA 18d948eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c3b68 - Browse repository at this point
Copy the full SHA b7c3b68View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10bdc28 - Browse repository at this point
Copy the full SHA 10bdc28View commit details
Commits on Aug 11, 2023
-
Apply suggestions from code review
Co-authored-by: Dmitry Markin <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e5e6af0 - Browse repository at this point
Copy the full SHA e5e6af0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25c12b2 - Browse repository at this point
Copy the full SHA 25c12b2View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.