Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[settings] should be optional when loading from TOML #254

Open
jmg-duarte opened this issue Sep 10, 2024 · 0 comments
Open

[settings] should be optional when loading from TOML #254

jmg-duarte opened this issue Sep 10, 2024 · 0 comments

Comments

@jmg-duarte
Copy link
Contributor

jmg-duarte commented Sep 10, 2024

Issue Description

The following code fails because I don't have a [settings] field in the TOML.
zombienet (the original project) works without and so should the SDK.

 zombienet_sdk::NetworkConfig::load_from_toml(
            "local-testnet.toml",
        )
        .unwrap();

Steps to reproduce the issue

Steps to reproduce the issue

  1. Don't put a [settings] field in a TOML file

Alternatively, load this example: https://github.com/paritytech/zombienet/blob/main/examples/0001-small-network.toml

Describe the results you received

Error because of the missing field

Describe the results you expected

A default [settings] should be used instead.

Serde allows for this.

Zombienet version

NA

Provider

Native

Provider version

NA

Upstream Latest Release

Yes

Additional environment details

NA

Additional information

I can help implement this

Screenshots

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant