Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print the wavespeed that sets the CFL timestep #73

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

BenWibking
Copy link
Contributor

@BenWibking BenWibking commented Jul 10, 2023

This modifies the timestep reduction to include the cell properties, and prints the wavespeeds (sound speed, Alfven speed, and fluid velocity) for the cell that has the minimum timestep.

When running the Orzsag-Tang problem, the output looks like this:

----> dt = 6.94e-04 (c_s = 1.00e+00, v_A = 1.78e-02, |v| = 1.86e-02)
        Timestep limited by sound speed.
cycle=27 time=1.8915349544324910e-02 dt=6.9398393409190106e-04 zone-cycles/wsec_step=2.32e+06 wsec_total=7.54e-01 wsec_step=2.83e-02

@BenWibking BenWibking marked this pull request as ready for review July 10, 2023 19:47
@BenWibking
Copy link
Contributor Author

@forrestglines do you want to try this out? I think it should work, but it could use some testing.

You should be able to immediately modify it to compute and print out the temperature/sound speed, Alfven speed, and bulk velocity from the primitive vars of the timestep-limiting cell.

@BenWibking BenWibking changed the title WIP: print which cell sets the CFL timestep WIP: print the cell that sets the CFL timestep Jul 10, 2023
@BenWibking BenWibking closed this Jan 26, 2024
@BenWibking BenWibking reopened this Nov 9, 2024
@BenWibking BenWibking changed the title WIP: print the cell that sets the CFL timestep Print the wavespeed that sets the CFL timestep Nov 9, 2024
@BenWibking
Copy link
Contributor Author

@pgrete Could you take a look at this?

I can also add a runtime option to turn this on/off if that would be useful.

@BenWibking
Copy link
Contributor Author

BenWibking commented Nov 17, 2024

Several of the tests fail with a CUDA memory error:

Setup complete, executing driver...

(ptr->cuda_stream_synchronize_wrapper(stream)) error( cudaErrorIllegalAddress): an illegal memory access was encountered /__w/athenapk/athenapk/external/Kokkos/core/src/Cuda/Kokkos_Cuda_Instance.cpp:165
Backtrace:

I will try to debug on the HPCC tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant