Add particle flash --tachyon
#780
Conversation
keeramis
force-pushed
the
feature/linux-flashing
branch
from
b4660c2 to
8d62e71
Compare
src/cli/flash.js
Outdated
| boolean: true, | ||
| description: 'Flash Tachyon' | ||
| }, | ||
| 'verbose' : { |
There was a problem hiding this comment.
You don't need to add verbose here. It's a global flag available to all commands already https://github.com/particle-iot/particle-cli/blob/master/src/app/cli.js#L42
src/cmd/flash.js
Outdated
| const rawProgramFiles = linxuFiles.filter(f => f.startsWith('rawprogram') && f.endsWith('.xml')); | ||
| const patchFiles = linxuFiles.filter(f => f.startsWith('patch') && f.endsWith('.xml')); | ||
|
|
||
| if (!elfFiles.length || !rawProgramFiles.length || !patchFiles.length) { |
There was a problem hiding this comment.
I don't think patch files are mandatory.
| throw new Error('The directory should contain at least one .elf file, one rawprogram file, and one patch file'); | ||
| } | ||
|
|
||
| const sortByNumber = (a, b) => { |
There was a problem hiding this comment.
I don't think it's necessary to sort the files, as long as the program files are before the patch files.
There was a problem hiding this comment.
I think you want to process in the order given in the command. The original tools assume that the user correctly orders the raw program and patch files accordingly
There was a problem hiding this comment.
I brought these back (for time being) and kept the below changes as well (assuming they are important too)
| rawProgramFiles.sort(sortByNumber); | ||
| patchFiles.sort(sortByNumber); | ||
|
|
||
| if (rawProgramFiles.length !== patchFiles.length) { |
There was a problem hiding this comment.
I don't think this is necessary either
There was a problem hiding this comment.
I really think this is extra. What if a program doesn't have a patch file to go with it?
| throw new Error('The number of rawprogram files should match the number of patch files'); | ||
| } | ||
|
|
||
| let filesToProgram = []; |
There was a problem hiding this comment.
| let filesToProgram = []; | |
| const filesToProgram = [...rawProgramFiles, ...patchFiles]; |
src/cmd/flash.js
Outdated
| unpackToolFolder = path.dirname(files[0]); | ||
| } | ||
|
|
||
| const parsedFiles = await this._analyzeFiles(files); |
There was a problem hiding this comment.
Looking at the implementation of _analyzeFiles, I'm not sure this call is useful
keeramis
force-pushed
the
feature/linux-flashing
branch
from
812ed57 to
93ba5ba
Compare
There was a problem hiding this comment.
The directory must be <os>_<architecture> like darwin_x64. Use the same words as in https://binaries.particle.io/particle-cli/manifest.json
| let linxuFiles = await this._findLinuxExecutableFiles(files, { directory: unpackToolFolder }); | ||
| linxuFiles = linxuFiles.map(f => path.basename(f)); | ||
|
|
||
| const elfFiles = linxuFiles.filter(f => f.startsWith('prog') && f.endsWith('.elf')); |
There was a problem hiding this comment.
Change the criteria to
| const elfFiles = linxuFiles.filter(f => f.startsWith('prog') && f.endsWith('.elf')); | |
| const elfFiles = linxuFiles.filter(f => f.includes('firehose') && f.endsWith('.elf')); |
| const archType = utilities.getArchType(); | ||
| const qdl = path.join(__dirname, `../../assets/qdl/${archType}/qdl`); | ||
| await fs.ensureFile(qdl); |
There was a problem hiding this comment.
Another piece of feedback: extract the execution of qdl to a separate file lib/qdl.js. See the example of the old dfu.js https://github.com/particle-iot/particle-cli/blob/v1.43.2/src/lib/dfu.js
Keep using the new execa, but put stuff like getting the correct executable for the current OS and platform in a helper function in lib/qdl.js so that flash.js just needs to call a function to perform the qdl flash.
Description
Add
particle flash --tachyonto flash tachyonStory: https://app.shortcut.com/particle/story/132827/create-particle-flash-tachyon-command
Usage
nvm useto update the node version and then runnpm ciOne of the following ways to test the command:
qcm6490_qfil_download_ufsfolder - Runparticle flash --tachyonnpm start -- flash --tachyon /path/to/qcm6490_qfil_download_ufsqcm6490_qfil_download_ufsfolder - Runnpm start -- flash --tachyon prog_firehose_ddr.elf rawprogram_unsparse0.xml patch0.xml rawprogram1.xml patch1.xml rawprogram2.xml patch2.xml rawprogram3.xml patch3.xml rawprogram4.xml patch4.xml rawprogram5.xml patch5.xmlUse
--verboseto see logs during the update processExpected output
See this slack thread -
Related Issues / Discussions
Story
Completeness