Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend support for batch operation mocking / assertions #151

Closed
wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Aug 16, 2023

Description

This PR extends the support for batch operation mocking and assertions in the pgxmock package. It addresses issue #149 by modifying the SendBatch method, adding a new type ExpectedBatch, and introducing a new method ExpectBatch to the pgxmock type. Additionally, the ExpectationsWereMet method is updated to check if all expected batch operations were met.

Summary of Changes

  • Modified the SendBatch method in pgxmock.go to return mock batch results based on the queued expectations.
  • Added a new type ExpectedBatch in pgxmock.go to represent an expected batch operation, including the expected SQL statements and their arguments, as well as methods to set the expected results or errors.
  • Added a new method ExpectBatch in pgxmock.go to queue an expected batch operation. This method returns an ExpectedBatch instance that can be configured in tests.
  • Updated the ExpectationsWereMet method in pgxmock.go to also check if all expected batch operations were met.
  • Added unit tests in pgxmock_test.go to cover the new ExpectBatch method and the modified SendBatch method. These tests cover various scenarios, including successful batch operations, batch operations that result in errors, and batch operations that do not meet the expectations.

Fixes #149.


To checkout this PR branch, run the following command in your terminal:

git checkout sweep/batch-operation-mocking

To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.

@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Aug 16, 2023
@pashagolub pashagolub self-assigned this Aug 17, 2023
@pashagolub pashagolub added the enhancement New feature or request label Aug 17, 2023
@pashagolub pashagolub closed this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Extend support for batch operation mocking / assertions
1 participant