Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extend eco_prime to F_q? #5

Closed
benediamond opened this issue Nov 12, 2018 · 4 comments
Closed

extend eco_prime to F_q? #5

benediamond opened this issue Nov 12, 2018 · 4 comments

Comments

@benediamond
Copy link
Contributor

Thanks for your great work. I am very interested in extending many of the functions in eco_prime.h to arbitrary finite fields F_q. Most importantly, I'd like to extend compute_divisor_of_division_polynomial and its auxiliary functions (coefficient_comparison, compute_coefficients_of_weierstrass_p, etc.) to the prime-power case. Would there be any interest in this project on your part? I would be willing to contribute significantly, and have already made some progress. Thank you.

@mkoeppe
Copy link
Collaborator

mkoeppe commented Nov 13, 2018

See issue #6 - there are no active developers.

@benediamond
Copy link
Contributor Author

I have gone ahead and done this: see benediamond::f_q_support.

@benediamond
Copy link
Contributor Author

I've rebased my work to ensure clean diffs; you can now see it at my master branch. You can test it using examples/ec_order/eco_appl.

I don't suppose you have any interest in merging this in?

There may be a few bug fixes which are separate from the F_q business; I will go ahead and tag you in them.

@mkoeppe
Copy link
Collaborator

mkoeppe commented Aug 1, 2019

Thanks for doing that; this makes it easier to share bugfixes.

I don't plan to merge new features in my branch. If you have bug fixes that you'd like me to merge, it's probably best if you prepare pull requests for those; but no pressure! (I will probably not have the time to cherry-pick from the tagged code.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants