Skip to content

Commit

Permalink
deprecate PystoreConnector and ArcticConnectors
Browse files Browse the repository at this point in the history
- remove optional install options for these connectors from pyproject.toml
  • Loading branch information
dbrakenhoff committed Jun 26, 2024
1 parent 8f45fb9 commit 6eef039
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 9 deletions.
12 changes: 12 additions & 0 deletions pastastore/connectors.py
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,12 @@ def __init__(self, name: str, connstr: str):
connstr : str
connection string (e.g. 'mongodb://localhost:27017/')
"""
warnings.warn(
"ArcticConnector is deprecated. Please use a different "
"connector, e.g. `pst.ArcticDBConnector`.",
DeprecationWarning,
stacklevel=1,
)
try:
import arctic
except ModuleNotFoundError as e:
Expand Down Expand Up @@ -392,6 +398,12 @@ def __init__(self, name: str, path: str):
path : str
path to the pystore directory
"""
warnings.warn(
"PystoreConnector is deprecated. Please use a different "
"connector, e.g. `pst.PasConnector`.",
DeprecationWarning,
stacklevel=1,
)
try:
import pystore
except ModuleNotFoundError as e:
Expand Down
11 changes: 2 additions & 9 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -58,16 +58,9 @@ test = [
"pytest-dependency",
"pytest-benchmark",
"codacy-coverage",
"lxml", # temporary fix: for hydropandas 0.8.0
"lxml",
]
pystore = ["fsspec>=0.3.3", "python-snappy", "dask[dataframe]"]
arctic = [
"arctic", # will not work as releases not uploaded to PyPI
]
arcticdb = [
"arcticdb",
"protobuf~=4.0",
] # TODO: temporarily set protobuf to version 4
arcticdb = ["arcticdb"]
docs = [
"pastastore[optional]",
"sphinx_rtd_theme",
Expand Down

0 comments on commit 6eef039

Please sign in to comment.