-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
filter events in subscription engine #637
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
force-pushed
the
subscription-engine-filter-events
branch
from
October 6, 2024 08:34
113cd50
to
95c56c8
Compare
DanielBadura
reviewed
Oct 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should also add a NOT IN
event filter?
For which use case 🤔 |
Maybe for testing purposes, like checking what happens if an event will be dropped. It just came in my mind - nothing we need right away |
DavidBadura
force-pushed
the
subscription-engine-filter-events
branch
from
October 15, 2024 11:36
4ed8b77
to
bae4966
Compare
DavidBadura
force-pushed
the
subscription-engine-filter-events
branch
from
December 5, 2024 15:26
bae4966
to
f3b413f
Compare
DavidBadura
force-pushed
the
subscription-engine-filter-events
branch
from
December 8, 2024 11:59
b2a83be
to
96b8640
Compare
DavidBadura
force-pushed
the
subscription-engine-filter-events
branch
from
December 12, 2024 11:54
4a76066
to
ba4958e
Compare
DanielBadura
approved these changes
Dec 12, 2024
DavidBadura
force-pushed
the
subscription-engine-filter-events
branch
from
December 12, 2024 19:43
8b91a43
to
be1020b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to filter the stream by events. This allows us to optimize the subscription engine so that we only load the events that the subscriptions need.
In other words, before the stream is loaded, all subscriptions that are currently being used are checked to see which events are needed. This list is then used to load the stream with a filter. As soon as a subscriber hears
*
(all), all events are always loaded.This strategy is optional and can be tried out with the changed typehint for the store parameter in the subscription engine. The MessageLoader interface was introduced for this purpose.