-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Experimental] introduce event id & fix split stream logic in stream store #657
Open
DavidBadura
wants to merge
4
commits into
3.6.x
Choose a base branch
from
event-id
base: 3.6.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidBadura
force-pushed
the
event-id
branch
2 times, most recently
from
December 13, 2024 14:43
6fc81bd
to
1f23240
Compare
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
DavidBadura
force-pushed
the
event-id
branch
from
December 13, 2024 14:54
1f23240
to
f9729b3
Compare
DavidBadura
force-pushed
the
event-id
branch
from
December 13, 2024 16:48
6ecb6ad
to
8c9fbfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs #656
Each event now gets a unique ID when saved in the StreamStore. You can either set this externally using EventIdHeader or it is generated automatically internally.
Using the event ID, I was also able to solve the problem with the split stream and missing playhead. I adapted the archiving logic so that I can simply archive all messages in a stream that happened before a certain event ID.