Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent SEO Settings from inheriting from self #293

Open
philipdanielhayton opened this issue Oct 31, 2024 · 1 comment
Open

Prevent SEO Settings from inheriting from self #293

philipdanielhayton opened this issue Oct 31, 2024 · 1 comment

Comments

@philipdanielhayton
Copy link

Hi Patrick,

This is 100% a user-land issue and nothing at all to do with SeoToolkit, but I've just noticed an issue where if you set the SEO inheritance to the current document type, it will cause 500 server errors on any page of that doc type.

So for example on the HomePage document type, selecting SEO settings to inherit from HomePage.

The fix is simple enough; don't do it! 😅 But maybe there could be some kind of validation to prevent this kind of thing happening. But honestly, it's not at all important and I'm more just leaving this here in case anybody else (or even future me) has a brain fart like this. 😅

@patrickdemooij9
Copy link
Owner

Hi @philipdanielhayton
That indeed sounds like an issue 😅. I'll see if I can make it so that you can't choose the current document type.
Thank you for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants