ThresholdVerticalLine without SegmentProperties

[KORuL]

Question

Please explain how to make a vertical boundary line.
I wrote the following code, but it doesn’t take something into account, I don’t understand what’s missing

data class ThresholdVerticalLine(
    val thresholdRangeY: ClosedFloatingPointRange<Float>,
    val thresholdRangeX: ClosedFloatingPointRange<Float>,
    val thresholdLabel: CharSequence = RANGE_FORMAT.format(
        decimalFormat.format(thresholdRangeY.start),
        decimalFormat.format(thresholdRangeY.endInclusive),
    ),
    val lineComponent: ShapeComponent = ShapeComponent(),
    val minimumLineThicknessDp: Float = DefaultDimens.THRESHOLD_LINE_THICKNESS,
    val labelComponent: TextComponent = textComponent(),
    val labelHorizontalPosition: LabelHorizontalPosition = LabelHorizontalPosition.Start,
    val labelVerticalPosition: LabelVerticalPosition = LabelVerticalPosition.Top,
    val labelRotationDegrees: Float = 0f,
) : Decoration {

    override fun onDrawAboveChart(
        context: ChartDrawContext,
        bounds: RectF,
    ): Unit = with(context) {
        val chartValues = chartValuesProvider.getChartValues()

        val valueRangeY = chartValues.maxY - chartValues.minY

        val centerY = bounds.bottom - (thresholdRangeY.median - chartValues.minY) / valueRangeY * bounds.height()

        val topY = minOf(
            bounds.bottom - (thresholdRangeY.endInclusive - chartValues.minY) / valueRangeY * bounds.height(),
            centerY - minimumLineThicknessDp.pixels.half,
        ).ceil
        val bottomY = maxOf(
            bounds.bottom - (thresholdRangeY.start - chartValues.minY) / valueRangeY * bounds.height(),
            centerY + minimumLineThicknessDp.pixels.half,
        ).floor
        val textY = when (labelVerticalPosition) {
            LabelVerticalPosition.Top -> topY
            LabelVerticalPosition.Bottom -> bottomY
        }

        val chartRange = chartValues.maxX - chartValues.minX

        val left = (bounds.left + (thresholdRangeX.endInclusive - chartValues.minX) / chartRange * bounds.width() - minimumLineThicknessDp.pixels.half).ceil
        val right = (bounds.left + (thresholdRangeX.start - chartValues.minX) / chartRange * bounds.width() + minimumLineThicknessDp.pixels.half).floor

        lineComponent.draw(
            context = context,
            left = min(left, right),
            right = max(left, right),
            top = topY,
            bottom = bottomY,
        )
        labelComponent.drawText(
            context = context,
            text = thresholdLabel,
            maxTextWidth = bounds.width().toInt(),
            textX = when (labelHorizontalPosition) {
                LabelHorizontalPosition.Start -> bounds.getStart(isLtr = isLtr)
                LabelHorizontalPosition.End -> bounds.getEnd(isLtr = isLtr)
            },
            textY = textY,
            horizontalPosition = labelHorizontalPosition.position,
            verticalPosition = labelVerticalPosition.position.inBounds(
                bounds = bounds,
                componentHeight = labelComponent.getHeight(
                    context = context,
                    text = thresholdLabel,
                    rotationDegrees = labelRotationDegrees,
                ),
                y = textY,
            ),
            rotationDegrees = labelRotationDegrees,
        )
    }

    fun VerticalPosition.inBounds(
        bounds: RectF,
        distanceFromPoint: Float = 0f,
        componentHeight: Float,
        y: Float,
    ): VerticalPosition {
        val topFits = y - distanceFromPoint - componentHeight >= bounds.top
        val centerFits = y - componentHeight.half >= bounds.top && y + componentHeight.half <= bounds.bottom
        val bottomFits = y + distanceFromPoint + componentHeight <= bounds.bottom

        return when (this) {
            VerticalPosition.Top -> if (topFits) this else VerticalPosition.Bottom
            VerticalPosition.Bottom -> if (bottomFits) this else VerticalPosition.Top
            VerticalPosition.Center -> when {
                centerFits -> this
                topFits -> VerticalPosition.Top
                else -> VerticalPosition.Bottom
            }
        }
    }


    /**
     * Defines the horizontal position of a [ThresholdLine]’s label.
     *
     * @property position the label position.
     */
    enum class LabelHorizontalPosition(val position: HorizontalPosition) {
        Start(HorizontalPosition.End),
        End(HorizontalPosition.Start),
    }

    /**
     * Defines the vertical position of a [ThresholdLine]’s label.
     *
     * @property position the label position.
     */
    enum class LabelVerticalPosition(val position: VerticalPosition) {
        Top(VerticalPosition.Top),
        Bottom(VerticalPosition.Bottom),
    }

    private companion object {
        const val RANGE_FORMAT = "%s–%s"
        val decimalFormat = DecimalFormat("#.##")
    }
}

Vico version(s)

1.15.0

UI framework(s)

No response

[KORuL]

I see #273
But the code is now not working, because there are no SegmentProperties, and I have not found an analogue of segmentWidth marginWidth

[Gowsky]

Hello @KORuL, please see ChartDrawContext.horizontalDimensions.

[KORuL]

Please help me with my code.
I saw this class, it doesn't helped me

[Gowsky]

This should work. Please note that this code doesn't consider horizontal scroll and RTL layouts, but you can improve it easily if needed. You can also modify it to consider the minimum thickness, as in your code sample.

val left =
    bounds.left +
        horizontalDimensions.startPadding +
        (thresholdRangeX.start - chartValues.minX) / chartValues.xStep * horizontalDimensions.xSpacing
val right =
    left + (thresholdRangeX.endInclusive - thresholdRangeX.start) / chartValues.xStep * horizontalDimensions.xSpacing