Skip to content

Commit

Permalink
[benchmark] Support GCR and Artifact Registry.
Browse files Browse the repository at this point in the history
We have base images that still need to be migrated (for instance, from
marketplace.gcr.io). This change restores support for GCR, to be
maintained until all images are migrated.
  • Loading branch information
paulosjca committed Aug 29, 2024
1 parent f71cdc7 commit 42924fc
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 12 deletions.
7 changes: 4 additions & 3 deletions tools/internal_ci/linux/grpc_e2e_performance_gke.sh
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,10 @@ WORKER_POOL_32CORE=workers-c2-30core-ci
# Prefix for log URLs in cnsviewer.
LOG_URL_PREFIX="http://cnsviewer/placer/prod/home/kokoro-dedicated/build_artifacts/${KOKORO_BUILD_ARTIFACTS_SUBDIR}/github/grpc/"

# This is to ensure we can push and pull images from Artifact Registry. We do
# not necessarily need it to run load tests, but will need it when we employ
# pre-built images in the optimization.
# This is to ensure we can push and pull images from GCR and Artifact Registry.
# We do not necessarily need it to run load tests, but will need it when we
# employ pre-built images in the optimization.
gcloud auth configure-docker
gcloud auth configure-docker "${PREBUILT_IMAGE_PREFIX%%/*}"

# Connect to benchmarks-prod2 cluster.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,10 @@ WORKER_POOL_32CORE=workers-c2-30core-ci
# Prefix for log URLs in cnsviewer.
LOG_URL_PREFIX="http://cnsviewer/placer/prod/home/kokoro-dedicated/build_artifacts/${KOKORO_BUILD_ARTIFACTS_SUBDIR}/github/grpc/"

# This is to ensure we can push and pull images from Artifact Registry. We do
# not necessarily need it to run load tests, but will need it when we employ
# pre-built images in the optimization.
# This is to ensure we can push and pull images from GCR and Artifact Registry.
# We do not necessarily need it to run load tests, but will need it when we
# employ pre-built images in the optimization.
gcloud auth configure-docker
gcloud auth configure-docker "${PREBUILT_IMAGE_PREFIX%%/*}"

# Connect to benchmarks-prod2 cluster.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,10 @@ WORKER_POOL_32CORE=workers-c2-30core-ci
# Prefix for log URLs in cnsviewer.
LOG_URL_PREFIX="http://cnsviewer/placer/prod/home/kokoro-dedicated/build_artifacts/${KOKORO_BUILD_ARTIFACTS_SUBDIR}/github/grpc/"

# This is to ensure we can push and pull images from Artifact Registry. We do
# not necessarily need it to run load tests, but will need it when we employ
# pre-built images in the optimization.
# This is to ensure we can push and pull images from GCR and Artifact Registry.
# We do not necessarily need it to run load tests, but will need it when we
# employ pre-built images in the optimization.
gcloud auth configure-docker
gcloud auth configure-docker "${PREBUILT_IMAGE_PREFIX%%/*}"

# Connect to benchmarks-prod2 cluster.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,10 @@ WORKER_POOL_8CORE=workers-c2-8core-ci
# Prefix for log URLs in cnsviewer.
LOG_URL_PREFIX="http://cnsviewer/placer/prod/home/kokoro-dedicated/build_artifacts/${KOKORO_BUILD_ARTIFACTS_SUBDIR}/github/grpc/"

# This is to ensure we can push and pull images from Artifact Registry. We do
# not necessarily need it to run load tests, but will need it when we employ
# pre-built images in the optimization.
# This is to ensure we can push and pull images from GCR and Artifact Registry.
# We do not necessarily need it to run load tests, but will need it when we
# employ pre-built images in the optimization.
gcloud auth configure-docker
gcloud auth configure-docker "${PREBUILT_IMAGE_PREFIX%%/*}"

# Connect to benchmarks-prod2 cluster.
Expand Down

0 comments on commit 42924fc

Please sign in to comment.